mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2026-03-30 11:10:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

xwayland: flush X11 connection after focus/activate

Browse source 
This mitigates a race where the XWayland server may generate an unwanted
FocusOut event for the newly activated window, if it receives mouse/
pointer events over the parallel wayland connection first.

In particular, this fixes an issue with certain fullscreen applications
(such as Minecraft) that self-minimize when receiving FocusOut.

Also limit a previous similar workaround to apply only to XWayland views.

Fixes: #3344

See also: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/4044
This commit is contained in:
John Lindgren 2026-02-04 11:41:28 -05:00 • committed by Consolatis
parent 12b6d05481
commit 81778a16bb
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/view.c
View file

@ -2242,7 +2242,9 @@ view_move_to_front(struct view *view)
* to an incorrect X window depending on timing. To mitigate the * to an incorrect X window depending on timing. To mitigate the
* race, perform an explicit flush after restacking. * race, perform an explicit flush after restacking.
*/ */
xwayland_flush(view->server); if (view->type == LAB_XWAYLAND_VIEW) {
xwayland_flush(view->server);
}
#endif #endif
cursor_update_focus(view->server); cursor_update_focus(view->server);
desktop_update_top_layer_visibility(view->server); desktop_update_top_layer_visibility(view->server);

8
src/xwayland.c
View file

@ -946,6 +946,14 @@ xwayland_view_set_activated(struct view *view, bool activated)
} }
wlr_xwayland_surface_activate(xwayland_surface, activated); wlr_xwayland_surface_activate(xwayland_surface, activated);
/*
* Make sure that the X11-protocol messages (SetInputFocus etc.)
* are sent immediately. This mitigates a race where the XWayland
* server may generate an unwanted FocusOut event for the newly
* activated window, if it receives mouse/pointer events over the
* parallel wayland connection first.
*/
xwayland_flush(view->server);
} }
static void static void