mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2026-04-07 08:21:20 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix/focus: remove <focusOnTitlebarEnter> option:

Browse source 
- follow-mouse on SSD titlebar/title/buttons will focus toplevel
  by default
This commit is contained in:
Maik Broemme 2025-11-15 15:43:20 +01:00
parent 0ee35b3dc0
commit 813739af69
No known key found for this signature in database
GPG key ID: 27BE1125704B8B02
4 changed files with 1 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/labwc-config.5.scd
View file

@ -491,12 +491,6 @@ this is for compatibility with Openbox.
*<focus><raiseOnFocus>* [yes|no]
Raise window to top when focused. Default is no.
*<focus><focusOnTitlebarEnter>* [yes|no]
When *followMouse* is enabled, also focus the toplevel when the
pointer enters the server-side decorated titlebar (including the
titlebar background, the window title text, and any titlebar buttons).
Default is no.
## WINDOW SNAPPING
Windows may be "snapped" to an edge or user-defined region of an output when

3
include/config/rcxml.h
View file

@ -199,9 +199,6 @@ struct rcxml {
float mag_scale;
float mag_increment;
bool mag_filter;
/* Focus behavior */
bool focus_titlebar_on_mouse_enter;
};
extern struct rcxml rc;

5
src/config/rcxml.c
View file

@ -1142,8 +1142,6 @@ entry(xmlNode *node, char *nodename, char *content)
set_bool(content, &rc.focus_follow_mouse_requires_movement);
} else if (!strcasecmp(nodename, "raiseOnFocus.focus")) {
set_bool(content, &rc.raise_on_focus);
} else if (!strcasecmp(nodename, "focusOnTitlebarEnter.focus")) {
set_bool(content, &rc.focus_titlebar_on_mouse_enter);
} else if (!strcasecmp(nodename, "doubleClickTime.mouse")) {
long doubleclick_time_parsed = strtol(content, NULL, 10);
if (doubleclick_time_parsed > 0) {
@ -1408,9 +1406,6 @@ rcxml_init(void)
}
has_run = true;
/* default: don't focus on titlebar enter */
rc.focus_titlebar_on_mouse_enter = false;
rc.placement_policy = LAB_PLACE_CASCADE;
rc.placement_cascade_offset_x = 0;
rc.placement_cascade_offset_y = 0;

3
src/input/cursor.c
View file

@ -563,8 +563,7 @@ cursor_update_common(struct server *server, struct cursor_context *ctx,
* a drag operation.
*/
wlr_seat_pointer_notify_clear_focus(wlr_seat);
/* Optional: focus toplevel when entering SSD titlebar/title/buttons */
if (rc.focus_follow_mouse && rc.focus_titlebar_on_mouse_enter && ctx->view) {
if (rc.focus_follow_mouse && ctx->view) {
/* Titlebar region, window title, or any titlebar button */
if (ctx->type == LAB_NODE_TITLEBAR || ctx->type == LAB_NODE_TITLE
|| node_type_contains(LAB_NODE_BUTTON, ctx->type)) {