mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-11 13:30:04 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

scaled-scene-buffer: reduce unnecessary renderings

Browse source 
Prior to this commit, a backing buffer with scale 1 was always created for
a scaled_scene_buffer before showing it, and backing buffers for specific
scales were created on output_enter events.

This commit removes this redundant re-renderings by calling
wlr_scene_buffer_set_dest_size() upon scaled_scene_buffer creation just to
receive output_enter events and delaying the first rendering to the first
output_enter event.

I needed to add font_get_buffer_size() to obtain the size of a font buffer
without actually creating it.
This commit is contained in:
tokyo4j 2024-12-03 16:18:52 +09:00 • committed by Hiroaki Yamamoto
parent cc838e79ed
commit 5db953aa89
6 changed files with 69 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/common/scaled-scene-buffer.c
View file

@ -228,7 +228,11 @@ scaled_scene_buffer_create(struct wlr_scene_tree *parent,
}
self->impl = impl;
self->active_scale = 1;
/*
* Set active scale to zero so that we always render a new buffer when
* entering the first output
*/
self->active_scale = 0;
self->drop_buffer = drop_buffer;
wl_list_init(&self->cache);
@ -254,7 +258,8 @@ scaled_scene_buffer_create(struct wlr_scene_tree *parent,
}
void
scaled_scene_buffer_invalidate_cache(struct scaled_scene_buffer *self)
scaled_scene_buffer_request_update(struct scaled_scene_buffer *self,
int width, int height)
{
assert(self);
struct scaled_scene_buffer_cache_entry *cache_entry, *cache_entry_tmp;
@ -262,5 +267,22 @@ scaled_scene_buffer_invalidate_cache(struct scaled_scene_buffer *self)
_cache_entry_destroy(cache_entry, self->drop_buffer);
}
assert(wl_list_empty(&self->cache));
_update_buffer(self, self->active_scale);
/*
* Tell wlroots about the buffer size so we can receive output_enter
* events even when the actual backing buffer is not set yet.
* The buffer size set here is updated when the backing buffer is
* created in _update_buffer().
*/
wlr_scene_buffer_set_dest_size(self->scene_buffer, width, height);
self->width = width;
self->height = height;
/*
* Skip re-rendering if the buffer is not shown yet
* TODO: don't re-render also when the buffer is temporarily invisible
*/
if (self->active_scale > 0) {
_update_buffer(self, self->active_scale);
}
}