mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-07 13:30:06 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

output: fallback to other output modes if preferred mode fails

Browse source 
See sway@4cdc4ac6

Sometimes the preferred mode is not available due to hardware
constraints. In these cases it is better to fallback to lower modes than
to end up with a black screen.
This commit is contained in:
Johan Malm 2021-08-22 14:14:50 +01:00
parent 8c96c65018
commit 5cf4539827
1 changed files with 29 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/output.c
View file

@ -828,20 +828,41 @@ output_destroy_notify(struct wl_listener *listener, void *data)
static void static void
new_output_notify(struct wl_listener *listener, void *data) new_output_notify(struct wl_listener *listener, void *data)
{ {
/* This event is rasied by the backend when a new output (aka a display /*
* or monitor) becomes available. */ * This event is rasied by the backend when a new output (aka display
* or monitor) becomes available.
*/
struct server *server = wl_container_of(listener, server, new_output); struct server *server = wl_container_of(listener, server, new_output);
struct wlr_output *wlr_output = data; struct wlr_output *wlr_output = data;
/* The mode is a tuple of (width, height, refresh rate). */
wlr_log(WLR_DEBUG, "set preferred mode");
struct wlr_output_mode *preferred_mode =
wlr_output_preferred_mode(wlr_output);
wlr_output_set_mode(wlr_output, preferred_mode);
/* /*
* The mode is a tuple of (width, height, refresh rate). * Sometimes the preferred mode is not available due to hardware
* TODO: support user configuration * constraints (e.g. GPU or cable bandwidth limitations). In these
* cases it's better to fallback to lower modes than to end up with
* a black screen. See sway@4cdc4ac6
*/ */
struct wlr_output_mode *mode = wlr_output_preferred_mode(wlr_output); if (!wlr_output_test(wlr_output)) {
if (mode) { wlr_log(WLR_DEBUG, "preferred mode rejected, falling back to "
wlr_output_set_mode(wlr_output, mode); "another mode");
wlr_output_commit(wlr_output); struct wlr_output_mode *mode;
wl_list_for_each(mode, &wlr_output->modes, link) {
if (mode == preferred_mode) {
continue;
} }
wlr_output_set_mode(wlr_output, mode);
if (wlr_output_test(wlr_output)) {
break;
}
}
}
wlr_output_commit(wlr_output);
struct output *output = calloc(1, sizeof(struct output)); struct output *output = calloc(1, sizeof(struct output));
output->wlr_output = wlr_output; output->wlr_output = wlr_output;