From 4f007109f6097a1c6f519e046dd816718e3c748f Mon Sep 17 00:00:00 2001 From: tokyo4j Date: Wed, 23 Oct 2024 20:47:48 +0900 Subject: [PATCH] menu: fix UAF in client-list-combined-menu after window destruction client-list-combined-menu should be updated when a window is destroyed, otherwise we get SEGFAULT when selecting an old window entry in it. --- src/view.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/view.c b/src/view.c index bcb86ea0..709b0ae1 100644 --- a/src/view.c +++ b/src/view.c @@ -2473,5 +2473,6 @@ view_destroy(struct view *view) wl_list_remove(&view->link); free(view); + update_client_list_combined_menu(server); cursor_update_focus(server); }