From 4eb34f97dedababc8a6607136fea16882b4cde2d Mon Sep 17 00:00:00 2001 From: John Lindgren Date: Tue, 13 Feb 2024 22:32:14 -0500 Subject: [PATCH] xwayland: remove "try to focus on parent surface" logic This was apparently to fix an Intellij focus issue, but I don't see any issues with Intellij currently, and the logic is wrong when the parent XWayland surface doesn't want focus (e.g. an XWayland panel with a focusable applications menu). --- src/xwayland-unmanaged.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/xwayland-unmanaged.c b/src/xwayland-unmanaged.c index 036b702b..72dce1ff 100644 --- a/src/xwayland-unmanaged.c +++ b/src/xwayland-unmanaged.c @@ -62,16 +62,6 @@ handle_map(struct wl_listener *listener, void *data) static void focus_next_surface(struct server *server, struct wlr_xwayland_surface *xsurface) { - /* - * Try to focus on parent surface - * This seems to fix JetBrains/Intellij window focus issues - */ - if (xsurface->parent && xsurface->parent->surface - && wlr_xwayland_or_surface_wants_focus(xsurface->parent)) { - seat_focus_surface(&server->seat, xsurface->parent->surface); - return; - } - /* Try to focus on last created unmanaged xwayland surface */ struct xwayland_unmanaged *u; struct wl_list *list = &server->unmanaged_surfaces;