mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-05 13:29:58 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

xwayland: honor initially maximized requests via _NET_WM_STATE

Browse source 
X11 clients may request to be initially fullscreen or maximized by
setting hints in the _NET_WM_STATE property. For some reason, we are
currently only honoring fullscreen requests but not maximize.

The fixes issues with GTK apps (notably Firefox, but others as well)
not starting maximized.

There is a remaining issue that the window position may not be set
correctly after unmaximizing. This will be fixed in a follow-up commit.
This commit is contained in:
John Lindgren 2023-10-17 22:40:57 -04:00 • committed by Johan Malm
parent a047e4a4e3
commit 45a4b3c047
1 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/xwayland.c
View file

@ -508,9 +508,25 @@ xwayland_view_map(struct view *view)
view->mapped = true;
ensure_initial_geometry_and_output(view);
wlr_scene_node_set_enabled(&view->scene_tree->node, true);
if (!view->fullscreen && xwayland_surface->fullscreen) {
view_set_fullscreen(view, true);
}
/*
* Per the Extended Window Manager Hints (EWMH) spec: "The Window
* Manager SHOULD honor _NET_WM_STATE whenever a withdrawn window
* requests to be mapped."
*
* The following order of operations is intended to reduce the
* number of resize (Configure) events:
* 1. set fullscreen state
* 2. set decorations (depends on fullscreen state)
* 3. set maximized (geometry depends on decorations)
*
* TODO: support separate horizontal/vertical maximize
*/
bool maximize = xwayland_surface->maximized_horz
&& xwayland_surface->maximized_vert;
view_set_fullscreen(view, xwayland_surface->fullscreen);
view_set_decorations(view, want_deco(xwayland_surface));
view_maximize(view, maximize, /*store_natural_geometry*/ true);
if (view->surface != xwayland_surface->surface) {
if (view->surface) {
@ -538,8 +554,6 @@ xwayland_view_map(struct view *view)
}
if (!view->been_mapped) {
view_set_decorations(view, want_deco(xwayland_surface));
if (view_is_floating(view)) {
set_initial_position(view, xwayland_surface);
}