From 43fb969b19757d3126619c17d28a883ec917709a Mon Sep 17 00:00:00 2001 From: Consolatis <35009135+Consolatis@users.noreply.github.com> Date: Tue, 7 Mar 2023 17:58:15 +0100 Subject: [PATCH] src/keyboard.c: Fix wrong argument parsing The `wlr_keyboard.events.modifiers` signal does not use a `wlr_keyboard_key_event` as argument, instead it is a pointer to the `wlr_keyboard` instance which caused the signal. --- src/keyboard.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/keyboard.c b/src/keyboard.c index 5cfbaa05..d4d7ff75 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -53,7 +53,6 @@ keyboard_modifiers_notify(struct wl_listener *listener, void *data) struct keyboard *keyboard = wl_container_of(listener, keyboard, modifier); struct seat *seat = keyboard->base.seat; struct server *server = seat->server; - struct wlr_keyboard_key_event *event = data; struct wlr_keyboard *wlr_keyboard = keyboard->wlr_keyboard; if (server->input_mode == LAB_INPUT_STATE_MOVE) { @@ -63,8 +62,7 @@ keyboard_modifiers_notify(struct wl_listener *listener, void *data) if (server->osd_state.cycle_view || server->grabbed_view || seat->workspace_osd_shown_by_modifier) { - if (event->state == WL_KEYBOARD_KEY_STATE_RELEASED - && !keyboard_any_modifiers_pressed(wlr_keyboard)) { + if (!keyboard_any_modifiers_pressed(wlr_keyboard)) { if (server->osd_state.cycle_view) { if (key_state_nr_keys()) { should_cancel_cycling_on_next_key_release = true;