mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2026-03-18 05:33:53 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

view: save view->last_placement on initial positioning

Browse source 
Fix a regression introduced in 3f223fe5 where output layout changes may
move xdg views outside of the output layout with the error:
`view has no last placement info`. This happens also for X11 views if
they don't specify its own geometry on map.

Recent changes introduced `view->last_placement` which is used to
restore view positions after layout changes. This is supposed to be
updated when a view is mapped or manually moved by the user.

However, 3f223fe5 replaced `view_place_by_policy()` with
`view_compute_position_by_policy()` in the xdg view map handler. Unlike
`view_place_by_policy()`, this function does not update
`view->last_placement`, leaving it unset at the time of output layout
changes.

Therefore, this patch adds explicit calls to `view_save_last_placement()`
in the map handler to ensure `view->last_placement` is always set for
mapped views.
This commit is contained in:
tokyo4j 2026-03-08 18:44:59 +09:00 • committed by Hiroaki Yamamoto
parent 1f776466a8
commit 3bb4ccd22d
4 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/view.c
View file

@ -568,8 +568,6 @@ view_moved(struct view *view)
}
}
static void save_last_placement(struct view *view);
void
view_move_resize(struct view *view, struct wlr_box geo)
{
@ -589,7 +587,7 @@ view_move_resize(struct view *view, struct wlr_box geo)
* Not sure if it might have other side-effects though.
*/
if (!view->adjusting_for_layout_change) {
save_last_placement(view);
view_save_last_placement(view);
}
}
@ -1722,8 +1720,8 @@ view_set_fullscreen(struct view *view, bool fullscreen)
cursor_update_focus(view->server);
}
static void
save_last_placement(struct view *view)
void
view_save_last_placement(struct view *view)
{
assert(view);
struct output *output = view->output;