From 3923b27384046167d02c96ee96d24f3330058acf Mon Sep 17 00:00:00 2001 From: tokyo4j Date: Sun, 7 Sep 2025 22:10:27 +0900 Subject: [PATCH] desktop.c: don't print errors when cursor is on resize-indicator In f347a81, I thought there are only window contents and SSD under `view->scene_tree` and forgot about the resize-indicator. I also refactored the logic around it: - Remove `ret.node->type == WLR_SCENE_NODE_BUFFER` check since it's already done by `lab_wlr_surface_from_node()` - Eliminate duplicated call to `lab_wlr_surface_from_node()` --- src/desktop.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/desktop.c b/src/desktop.c index 099c493b..efd46dc5 100644 --- a/src/desktop.c +++ b/src/desktop.c @@ -303,13 +303,12 @@ get_cursor_context(struct server *server) case LAB_NODE_VIEW: case LAB_NODE_XDG_POPUP: ret.view = desc->view; - if (ret.node->type == WLR_SCENE_NODE_BUFFER - && lab_wlr_surface_from_node(ret.node)) { + ret.surface = lab_wlr_surface_from_node(ret.node); + if (ret.surface) { ret.type = LAB_NODE_CLIENT; - ret.surface = lab_wlr_surface_from_node(ret.node); } else { - /* should never be reached */ - wlr_log(WLR_ERROR, "cursor not on client or ssd"); + /* e.g. when cursor is on resize-indicator */ + ret.type = LAB_NODE_NONE; } return ret; case LAB_NODE_LAYER_SURFACE: