From 331ded032832135970149f0b0738e414fdb00295 Mon Sep 17 00:00:00 2001 From: Droc Date: Thu, 19 Sep 2024 14:53:12 -0500 Subject: [PATCH] client list combines fix empty title this adds a check for title being null or empty as well as existence of toplevel.handle --- src/menu/menu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/menu/menu.c b/src/menu/menu.c index 94b7b3f3..69bc6f39 100644 --- a/src/menu/menu.c +++ b/src/menu/menu.c @@ -1001,10 +1001,15 @@ update_client_list_combined_menu(struct server *server) wl_list_for_each(view, &server->views, link) { if (view->workspace == workspace) { + const char *title = view_get_string_prop(view, "title"); + if (!view->toplevel.handle || string_null_or_empty(title)) { + continue; + } + if (view == server->active_view) { buf_add(&buffer, "*"); } - buf_add(&buffer, view_get_string_prop(view, "title")); + buf_add(&buffer, title); current_item = item_create(menu, buffer.data, /*show arrow*/ false); current_item->id = xstrdup(menu->id);