mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2026-03-20 05:34:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix cleanup issues in xdg_surface_new

Browse source 
`view->surface` had not been set to a non-`NULL` value here, so it
was not yet appropriate to access its `resource` member. instead,
use the resource from the argument xdg_surface.

furthermore, we need to free the newly-allocated `xdg_toplevel_view`
before error return.
This commit is contained in:
bi4k8 2022-12-08 05:27:25 +00:00 • committed by Johan Malm
parent 1ebf5bce90
commit 272221dae2
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/xdg.c
View file

@ -420,7 +420,8 @@ xdg_surface_new(struct wl_listener *listener, void *data)
view->scene_tree, xdg_surface); view->scene_tree, xdg_surface);
if (!tree) { if (!tree) {
/* TODO: might need further clean up */ /* TODO: might need further clean up */
wl_resource_post_no_memory(view->surface->resource); wl_resource_post_no_memory(xdg_surface->resource);
free(xdg_toplevel_view);
return; return;
} }
view->scene_node = &tree->node; view->scene_node = &tree->node;