config: s/app_id/identifier/ for window-switcher field

...to be consistent with window rules.

The use of 'app_id' for window-switcher fields is hereby deprecated.
This commit is contained in:
Johan Malm 2023-08-20 20:24:46 +01:00 committed by Johan Malm
parent e5a6c57a6e
commit 206db43786
5 changed files with 14 additions and 6 deletions

View file

@ -143,7 +143,8 @@ Therefore, where multiple objects of the same kind are required (for example
- *type* Show view type ("xdg-shell" or "xwayland") - *type* Show view type ("xdg-shell" or "xwayland")
- *app_id* Show app_id (class for XWayland) - *identifier* Show identifier (app_id for native Wayland
windows and WM_CLASS for XWayland clients)
- *title* Show window title if different to app_id - *title* Show window title if different to app_id

View file

@ -39,10 +39,14 @@
</font> </font>
</theme> </theme>
<!--
Just as for window-rules, 'identifier' relates to app_id for native Wayland
windows and WM_CLASS for XWayland clients.
-->
<windowSwitcher show="yes" preview="yes" outlines="yes"> <windowSwitcher show="yes" preview="yes" outlines="yes">
<fields> <fields>
<field content="type" width="25%" /> <field content="type" width="25%" />
<field content="app_id" width="25%" /> <field content="identifier" width="25%" />
<field content="title" width="50%" /> <field content="title" width="50%" />
</fields> </fields>
</windowSwitcher> </windowSwitcher>

View file

@ -16,7 +16,7 @@
enum window_switcher_field_content { enum window_switcher_field_content {
LAB_FIELD_NONE = 0, LAB_FIELD_NONE = 0,
LAB_FIELD_TYPE, LAB_FIELD_TYPE,
LAB_FIELD_APP_ID, LAB_FIELD_IDENTIFIER,
LAB_FIELD_TITLE, LAB_FIELD_TITLE,
}; };

View file

@ -183,8 +183,11 @@ fill_window_switcher_field(char *nodename, char *content)
} else if (!strcmp(nodename, "content")) { } else if (!strcmp(nodename, "content")) {
if (!strcmp(content, "type")) { if (!strcmp(content, "type")) {
current_field->content = LAB_FIELD_TYPE; current_field->content = LAB_FIELD_TYPE;
} else if (!strcmp(content, "identifier")) {
current_field->content = LAB_FIELD_IDENTIFIER;
} else if (!strcmp(content, "app_id")) { } else if (!strcmp(content, "app_id")) {
current_field->content = LAB_FIELD_APP_ID; wlr_log(WLR_ERROR, "window-switcher field 'app_id' is deprecated");
current_field->content = LAB_FIELD_IDENTIFIER;
} else if (!strcmp(content, "title")) { } else if (!strcmp(content, "title")) {
current_field->content = LAB_FIELD_TITLE; current_field->content = LAB_FIELD_TITLE;
} else { } else {
@ -1054,7 +1057,7 @@ static struct {
int width; int width;
} fields[] = { } fields[] = {
{ LAB_FIELD_TYPE, 25 }, { LAB_FIELD_TYPE, 25 },
{ LAB_FIELD_APP_ID, 25 }, { LAB_FIELD_IDENTIFIER, 25 },
{ LAB_FIELD_TITLE, 50 }, { LAB_FIELD_TITLE, 50 },
{ LAB_FIELD_NONE, 0 }, { LAB_FIELD_NONE, 0 },
}; };

View file

@ -352,7 +352,7 @@ render_osd(struct server *server, cairo_t *cairo, int w, int h,
case LAB_FIELD_TYPE: case LAB_FIELD_TYPE:
buf_add(&buf, get_type(*view)); buf_add(&buf, get_type(*view));
break; break;
case LAB_FIELD_APP_ID: case LAB_FIELD_IDENTIFIER:
buf_add(&buf, get_app_id(*view)); buf_add(&buf, get_app_id(*view));
break; break;
case LAB_FIELD_TITLE: case LAB_FIELD_TITLE: