mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-04 13:30:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

src/ssd/ssd_titlebar.c: Completely hide title when running out of space

Browse source 
Before this commit the window title could overflow in certain conditions,
usually when rapidly resizing. This commit fixes it by completely hiding
the corresponding scene node when there is no space available.

Reported-by: <peperino> via IRC
This commit is contained in:
Consolatis 2022-08-12 14:12:31 +02:00 • committed by Johan Malm
parent a610aff946
commit 1cdebbc22d
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/ssd/ssd_titlebar.c
View file

@ -142,6 +142,11 @@ ssd_titlebar_destroy(struct view *view)
* .active and .inactive may result in different sizes * .active and .inactive may result in different sizes
* of the title (font family/size) or background of * of the title (font family/size) or background of
* the title (different button/border width). * the title (different button/border width).
*
* Both, wlr_scene_node_set_enabled() and wlr_scene_node_set_position()
* check for actual changes and return early if there is no change in state.
* Always using wlr_scene_node_set_enabled(node, true) will thus not cause
* any unnecessary screen damage and makes the code easier to follow.
*/ */
static void static void
@ -167,10 +172,12 @@ ssd_update_title_positions(struct view *view)
buffer_height = part->buffer ? part->buffer->height : 0; buffer_height = part->buffer ? part->buffer->height : 0;
x = BUTTON_WIDTH; x = BUTTON_WIDTH;
y = (theme->title_height - buffer_height) / 2; y = (theme->title_height - buffer_height) / 2;
if (title_bg_width <= 0) { if (title_bg_width <= 0) {
wlr_scene_node_set_position(part->node, x, y); wlr_scene_node_set_enabled(part->node, false);
continue; continue;
} }
wlr_scene_node_set_enabled(part->node, true);
if (theme->window_label_text_justify == LAB_JUSTIFY_CENTER) { if (theme->window_label_text_justify == LAB_JUSTIFY_CENTER) {
if (buffer_width + BUTTON_WIDTH * 2 <= title_bg_width) { if (buffer_width + BUTTON_WIDTH * 2 <= title_bg_width) {