src/foreign.c: refactor

This commit is contained in:
Consolatis 2023-02-01 09:27:25 +01:00 committed by Johan Malm
parent 82e9e866ec
commit 14a0c83ae0
4 changed files with 85 additions and 87 deletions

View file

@ -4,71 +4,71 @@
#include "workspaces.h"
static void
handle_toplevel_handle_request_minimize(struct wl_listener *listener, void *data)
handle_request_minimize(struct wl_listener *listener, void *data)
{
struct view *view = wl_container_of(listener, view,
toplevel_handle_request_minimize);
struct view *view = wl_container_of(listener, view, toplevel.minimize);
struct wlr_foreign_toplevel_handle_v1_minimized_event *event = data;
if (view) {
view_minimize(view, event->minimized);
}
view_minimize(view, event->minimized);
}
static void
handle_toplevel_handle_request_maximize(struct wl_listener *listener, void *data)
handle_request_maximize(struct wl_listener *listener, void *data)
{
struct view *view = wl_container_of(listener, view,
toplevel_handle_request_maximize);
struct view *view = wl_container_of(listener, view, toplevel.maximize);
struct wlr_foreign_toplevel_handle_v1_maximized_event *event = data;
if (view) {
view_maximize(view, event->maximized,
/*store_natural_geometry*/ true);
}
view_maximize(view, event->maximized, /*store_natural_geometry*/ true);
}
static void
handle_toplevel_handle_request_fullscreen(struct wl_listener *listener, void *data)
handle_request_fullscreen(struct wl_listener *listener, void *data)
{
struct view *view = wl_container_of(listener, view,
toplevel_handle_request_fullscreen);
struct view *view = wl_container_of(listener, view, toplevel.fullscreen);
struct wlr_foreign_toplevel_handle_v1_fullscreen_event *event = data;
if (view) {
view_set_fullscreen(view, event->fullscreen, NULL);
}
view_set_fullscreen(view, event->fullscreen, NULL);
}
static void
handle_toplevel_handle_request_activate(struct wl_listener *listener, void *data)
handle_request_activate(struct wl_listener *listener, void *data)
{
struct view *view = wl_container_of(listener, view,
toplevel_handle_request_activate);
struct view *view = wl_container_of(listener, view, toplevel.activate);
// struct wlr_foreign_toplevel_handle_v1_activated_event *event = data;
/* In a multi-seat world we would select seat based on event->seat here. */
if (view) {
if (view->workspace != view->server->workspace_current) {
workspaces_switch_to(view->workspace);
}
desktop_focus_and_activate_view(&view->server->seat, view);
desktop_move_to_front(view);
if (view->workspace != view->server->workspace_current) {
workspaces_switch_to(view->workspace);
}
desktop_focus_and_activate_view(&view->server->seat, view);
desktop_move_to_front(view);
}
static void
handle_toplevel_handle_request_close(struct wl_listener *listener, void *data)
handle_request_close(struct wl_listener *listener, void *data)
{
struct view *view = wl_container_of(listener, view,
toplevel_handle_request_close);
if (view) {
view_close(view);
}
struct view *view = wl_container_of(listener, view, toplevel.close);
view_close(view);
}
static void
handle_destroy(struct wl_listener *listener, void *data)
{
struct view *view = wl_container_of(listener, view, toplevel.destroy);
struct foreign_toplevel *toplevel = &view->toplevel;
wl_list_remove(&toplevel->maximize.link);
wl_list_remove(&toplevel->minimize.link);
wl_list_remove(&toplevel->fullscreen.link);
wl_list_remove(&toplevel->activate.link);
wl_list_remove(&toplevel->close.link);
wl_list_remove(&toplevel->destroy.link);
toplevel->handle = NULL;
}
void
foreign_toplevel_handle_create(struct view *view)
{
view->toplevel_handle = wlr_foreign_toplevel_handle_v1_create(
struct foreign_toplevel *toplevel = &view->toplevel;
toplevel->handle = wlr_foreign_toplevel_handle_v1_create(
view->server->foreign_toplevel_manager);
if (!view->toplevel_handle) {
if (!toplevel->handle) {
wlr_log(WLR_ERROR, "cannot create foreign toplevel handle for (%s)",
view_get_string_prop(view, "title"));
return;
@ -80,33 +80,28 @@ foreign_toplevel_handle_create(struct view *view)
view_get_string_prop(view, "title"));
return;
}
wlr_foreign_toplevel_handle_v1_output_enter(view->toplevel_handle,
wlr_output);
wlr_foreign_toplevel_handle_v1_output_enter(toplevel->handle, wlr_output);
view->toplevel_handle_request_maximize.notify =
handle_toplevel_handle_request_maximize;
wl_signal_add(&view->toplevel_handle->events.request_maximize,
&view->toplevel_handle_request_maximize);
toplevel->maximize.notify = handle_request_maximize;
wl_signal_add(&toplevel->handle->events.request_maximize,
&toplevel->maximize);
view->toplevel_handle_request_minimize.notify =
handle_toplevel_handle_request_minimize;
wl_signal_add(&view->toplevel_handle->events.request_minimize,
&view->toplevel_handle_request_minimize);
toplevel->minimize.notify = handle_request_minimize;
wl_signal_add(&toplevel->handle->events.request_minimize,
&toplevel->minimize);
view->toplevel_handle_request_fullscreen.notify =
handle_toplevel_handle_request_fullscreen;
wl_signal_add(&view->toplevel_handle->events.request_fullscreen,
&view->toplevel_handle_request_fullscreen);
toplevel->fullscreen.notify = handle_request_fullscreen;
wl_signal_add(&toplevel->handle->events.request_fullscreen,
&toplevel->fullscreen);
view->toplevel_handle_request_activate.notify =
handle_toplevel_handle_request_activate;
wl_signal_add(&view->toplevel_handle->events.request_activate,
&view->toplevel_handle_request_activate);
toplevel->activate.notify = handle_request_activate;
wl_signal_add(&toplevel->handle->events.request_activate,
&toplevel->activate);
view->toplevel_handle_request_close.notify =
handle_toplevel_handle_request_close;
wl_signal_add(&view->toplevel_handle->events.request_close,
&view->toplevel_handle_request_close);
toplevel->close.notify = handle_request_close;
wl_signal_add(&toplevel->handle->events.request_close,
&toplevel->close);
/* TODO: hook up remaining signals (destroy) */
toplevel->destroy.notify = handle_destroy;
wl_signal_add(&toplevel->handle->events.destroy, &toplevel->destroy);
}