mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-03 09:01:51 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

view: fix NULL string_prop crash

Browse source 
...when app_id is NULL.

Make sure view_get_string_prop() never returns NULL because it is so easy
to misuse. Same for the respective xwayland/xdg impl methods in case
anyone decides to (incorrectly) call them directly in future.

Fixes: #2453
This commit is contained in:
Johan Malm 2024-12-27 22:37:35 +00:00 • committed by Johan Malm
parent bad788ccdd
commit 023427b4f4
3 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/xdg.c
View file

@ -660,10 +660,10 @@ xdg_toplevel_view_get_string_prop(struct view *view, const char *prop)
}
if (!strcmp(prop, "title")) {
return xdg_toplevel->title;
return xdg_toplevel->title ? xdg_toplevel->title : "";
}
if (!strcmp(prop, "app_id")) {
return xdg_toplevel->app_id;
return xdg_toplevel->app_id ? xdg_toplevel->app_id : "";
}
return "";
}