mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-10-31 22:25:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
labwc/include/input/key-state.h

29 lines
1,009 B
C
Raw Permalink Normal View History

keyboard: absolve release event if press was bound When key press events are handled by compositor keybindings, do not forward the corresponding release events to clients.
2021-12-21 22:25:59 +00:00
/* SPDX-License-Identifier: GPL-2.0-only */
includes: identifier consistency in include guards Made all header files to have LABWC_ prefix in include guard identifers. Converted from __LABWC_ in 35 include/ files. Converted from __LAB_ in 5 include/ files. Added LABWC prefix to 3 include/ files. Added include guards to 3 include/ files. The double underscores were removed since according to C standard those "are always reserved for any use".
2023-05-13 16:10:33 +03:00
#ifndef LABWC_KEY_STATE_H
#define LABWC_KEY_STATE_H
keyboard: absolve release event if press was bound When key press events are handled by compositor keybindings, do not forward the corresponding release events to clients.
2021-12-21 22:25:59 +00:00
keyboard: avoid stuck keys due to keybindings (alternate approach) Before commit e77330bc3fe7, there were issues with keys becoming "stuck" if other keys were pressed at the time a keybinding was matched, because those other keys were included in the "bound" set and the release events were incorrectly eaten by labwc. Commit e77330bc3fe7 solved that issue with the "big hammer" approach of preventing keybindings from working at all if other keys were pressed: if (key_state_nr_pressed_keys() > 1) { return false; } This is an alternate approach to solving the original problem, by (1) not including those other keys in the "bound" set and (2) making sure we always forward release events for un-bound keys to clients (even if a menu or OSD is displayed). Details: - Since we only ever want to store the single matched keycode as bound, key_state_store_pressed_keys_as_bound() doesn't really make sense in the plural, so rename it to key_state_store_pressed_key_as_bound() and pass in the keycode. - The calls to key_state_store_pressed_keys_as_bound() within handle_keybinding() appear to be redundant since it is also called from the parent function (handle_compositor_keybindings()). So remove these calls. - Finally, rework the logic for handling key-release events so that we always forward release events for keys not in the "bound" set. This PR does not remove the "key_state_nr_pressed_keys() > 1" check, and because of that should not result in any functional change. It should however make it possible to relax or remove that check in future.
2023-11-04 01:23:43 -04:00
#include <stdbool.h>
#include <stdint.h>
seat: only pass on sent keys on surface-focus Key events associated with keybindings (both pressed and released) are not sent to clients. When using wlr_seat_keyboard_notify_enter() it it therefore important not to send the keycodes of _all_ pressed keys, but only those that were actually _sent_ to clients (that is, those that were not bound). This approach is consistent with sway's implementation in input/seat.c https://github.com/swaywm/sway/blob/cffb006feba52c318e66f73c3463032fa76782dc/sway/input/seat.c#L173-L175 Fixes issue #510
2022-09-20 20:46:39 +01:00
/*
* All keycodes in these functions are (Linux) libinput evdev scancodes which is
* what 'wlr_keyboard' uses (e.g. 'seat->keyboard_group->keyboard->keycodes').
* Note: These keycodes are different to XKB scancodes by a value of 8.
*/
/**
* key_state_pressed_sent_keycodes - generate array of pressed+sent keys
* Note: The array is generated by subtracting any bound keys from _all_ pressed
* keys (because bound keys were not forwarded to clients).
*/
uint32_t *key_state_pressed_sent_keycodes(void);
int key_state_nr_pressed_sent_keycodes(void);
Revert "keyboard: include pressed modifiers in bound set" This reverts commit 98bf316ee6632f62ec205904d74eabd8b3e9d15b.
2024-12-23 00:05:22 +09:00
void key_state_set_pressed(uint32_t keycode, bool is_pressed);
keyboard: avoid stuck keys due to keybindings (alternate approach) Before commit e77330bc3fe7, there were issues with keys becoming "stuck" if other keys were pressed at the time a keybinding was matched, because those other keys were included in the "bound" set and the release events were incorrectly eaten by labwc. Commit e77330bc3fe7 solved that issue with the "big hammer" approach of preventing keybindings from working at all if other keys were pressed: if (key_state_nr_pressed_keys() > 1) { return false; } This is an alternate approach to solving the original problem, by (1) not including those other keys in the "bound" set and (2) making sure we always forward release events for un-bound keys to clients (even if a menu or OSD is displayed). Details: - Since we only ever want to store the single matched keycode as bound, key_state_store_pressed_keys_as_bound() doesn't really make sense in the plural, so rename it to key_state_store_pressed_key_as_bound() and pass in the keycode. - The calls to key_state_store_pressed_keys_as_bound() within handle_keybinding() appear to be redundant since it is also called from the parent function (handle_compositor_keybindings()). So remove these calls. - Finally, rework the logic for handling key-release events so that we always forward release events for keys not in the "bound" set. This PR does not remove the "key_state_nr_pressed_keys() > 1" check, and because of that should not result in any functional change. It should however make it possible to relax or remove that check in future.
2023-11-04 01:23:43 -04:00
void key_state_store_pressed_key_as_bound(uint32_t keycode);
keyboard: absolve release event if press was bound When key press events are handled by compositor keybindings, do not forward the corresponding release events to clients.
2021-12-21 22:25:59 +00:00
bool key_state_corresponding_press_event_was_bound(uint32_t keycode);
Revert "keyboard: cancel repeat when handling key-bind" This reverts commit e62bb51bfb33ee520e800cf98553d766824fe9cf. Fixes #510
2022-07-11 17:05:08 +01:00
void key_state_bound_key_remove(uint32_t keycode);
key-state: rename function for consistency ...with the equivalent function that returns the number of pressed keys. s/key_state_nr_keys/key_state_nr_bound_keys/
2023-09-30 09:19:59 +01:00
int key_state_nr_bound_keys(void);
keyboard: absolve release event if press was bound When key press events are handled by compositor keybindings, do not forward the corresponding release events to clients.
2021-12-21 22:25:59 +00:00
includes: identifier consistency in include guards Made all header files to have LABWC_ prefix in include guard identifers. Converted from __LABWC_ in 35 include/ files. Converted from __LAB_ in 5 include/ files. Added LABWC prefix to 3 include/ files. Added include guards to 3 include/ files. The double underscores were removed since according to C standard those "are always reserved for any use".
2023-05-13 16:10:33 +03:00
#endif /* LABWC_KEY_STATE_H */
Reference in a new issue Copy permalink