mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-03-29 07:58:01 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

osc: don't assert on \E]4 being followed by a ';'

Browse source 
This fixes a crash (in debug builds) that could be triggered by
e.g. cat:ing /dev/urandom.
This commit is contained in:
Daniel Eklöf 2020-06-09 17:33:26 +02:00
parent bf57d0c606
commit f72c982c89
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -57,6 +57,8 @@
* Sixel images being erased when printing text next to them. * Sixel images being erased when printing text next to them.
* Crash when last rendered cursor cell had scrolled off screen and * Crash when last rendered cursor cell had scrolled off screen and
`\E[J3` was executed. `\E[J3` was executed.
* Assert (debug builds) when an `\e]4` OSC escape was not followed by
a `;`.
### Security ### Security

3
osc.c
View file

@ -431,6 +431,9 @@ osc_dispatch(struct terminal *term)
/* Set color<idx> */ /* Set color<idx> */
string--; string--;
if (*string != ';')
break;
assert(*string == ';'); assert(*string == ';');
for (const char *s_idx = strtok(string, ";"), *s_color = strtok(NULL, ";"); for (const char *s_idx = strtok(string, ";"), *s_color = strtok(NULL, ";");