mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-05 04:06:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

url-mode: auto-detect: heuristics for parenthesis and brackets

Browse source 
While parenthesis and brackets _are_ valid URL characters, there are
many times when we do *not* want them to be part of the URL.

For example, in markdown we write “[text](url)”, or even
“[![alt-text](url-1)](url-2)”.

Here, the URLs are clearly *not* “url)” or “url-1)](url2)”.
This commit is contained in:
Daniel Eklöf 2021-02-01 09:55:18 +01:00
parent 9d8ec857ce
commit f61f7c131f
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
1 changed files with 40 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

47
url-mode.c
View file

@ -147,6 +147,9 @@ auto_detected(struct terminal *term)
wchar_t url[term->cols * term->rows + 1];
size_t len = 0;
ssize_t parenthesis = 0;
ssize_t brackets = 0;
for (int r = 0; r < term->rows; r++) {
const struct row *row = grid_row_in_view(term->grid, r);
@ -182,6 +185,8 @@ auto_detected(struct terminal *term)
wcsncpy(url, proto, prot_len);
len = prot_len;
parenthesis = brackets = 0;
break;
}
}
@ -193,18 +198,47 @@ auto_detected(struct terminal *term)
// static const wchar_t unwise[] = L"{}|\\^[]`";
// static const wchar_t reserved[] = L";/?:@&=+$,";
bool emit_url = false;
switch (wc) {
case L'a'...L'z':
case L'0'...L'9':
case L'-': case L'.': case L'_': case L'~': case L':':
case L'/': case L'?': case L'#': case L'[': case L']':
case L'@': case L'!': case L'$': case L'&': case L'\'':
case L'(': case L')': case L'*': case L'+': case L',':
case L';': case L'=': case L'"':
case L'/': case L'?': case L'#': case L'@': case L'!':
case L'$': case L'&': case L'\'': case L'*': case L'+':
case L',': case L';': case L'=': case L'"':
url[len++] = wc;
break;
default: {
case L'(':
parenthesis++;
url[len++] = wc;
break;
case L'[':
brackets++;
url[len++] = wc;
break;
case L')':
if (--parenthesis < 0)
emit_url = true;
else
url[len++] = wc;
break;
case L']':
if (--brackets < 0)
emit_url = true;
else
url[len++] = wc;
break;
default:
emit_url = true;
break;
}
if (emit_url) {
/* Heuristic to remove trailing characters that
* are valid URL characters, but typically not at
* the end of the URL */
@ -241,8 +275,7 @@ auto_detected(struct terminal *term)
state = STATE_PROTOCOL;
len = 0;
break;
}
parenthesis = brackets = 0;
}
break;
}