From e52d6e3fb8648c34e9e859db03ce3c0ad50ca952 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Tue, 23 Jul 2024 08:05:19 +0200 Subject: [PATCH] osc: kitty notifications: use xstrjoin() instead of xasprintf() --- osc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/osc.c b/osc.c index 6926c3ca..ef54f520 100644 --- a/osc.c +++ b/osc.c @@ -722,8 +722,6 @@ kitty_notification(struct terminal *term, char *string) } if (notif == NULL) { - /* Somewhat unoptimized... this will be free:d and removed - immediately if d=1 */ tll_push_front(term->notifications, ((struct notification){ .id = id, .icon = NULL, @@ -766,18 +764,18 @@ kitty_notification(struct terminal *term, char *string) notif->title = payload; payload = NULL; } else { - char *new_title = xasprintf("%s%s", notif->title, payload); - free(notif->title); - notif->title = new_title; + char *old_title = notif->title; + notif->title = xstrjoin(old_title, payload); + free(old_title); } } else { if (notif->body == NULL) { notif->body = payload; payload = NULL; } else { - char *new_body = xasprintf("%s%s", notif->body, payload); - free(notif->body); - notif->body = new_body; + char *old_body = notif->body; + notif->body = xstrjoin(old_body, payload); + free(old_body); } }