pgo: full-inner: add --override tweak.grapheme-shaping=no

Grapheme shaping is now enabled by default in foot. However, when
generating the profiling data in PGO builds, this results in skewed
optimizations.

The end result is worse benchmark results regardless of whether
grapheme-shaping is enabled or not (when running the benchmarks).
This commit is contained in:
Daniel Eklöf 2021-10-16 16:58:59 +02:00
parent f9782848e5
commit d4b365b55c
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
3 changed files with 8 additions and 1 deletions

View file

@ -47,6 +47,8 @@
itself, and fcft has been compiled with support for it.
* Default value of `[tweak].grapheme-width-method` changed from
`double-width` to `wcswidth`.
* INSTALL.md: `--override tweak.grapheme-shaping=no` added to PGO
command line.
### Deprecated

View file

@ -398,7 +398,11 @@ We will use the script `scripts/generate-alt-random-writes.py`:
```sh
./footclient --version
foot_tmp_file=$(mktemp)
./foot --config=/dev/null --term=xterm sh -c "<path-to-generate-alt-random-writes.py> --scroll --scroll-region --colors-regular --colors-bright --colors-256 --colors-rgb --attr-bold --attr-italic --attr-underline --sixel ${foot_tmp_file} && cat ${foot_tmp_file}"
./foot \
--config=/dev/null \
--override tweak.grapheme-shaping=no \
--term=xterm \
sh -c "<path-to-generate-alt-random-writes.py> --scroll --scroll-region --colors-regular --colors-bright --colors-256 --colors-rgb --attr-bold --attr-italic --attr-underline --sixel ${foot_tmp_file} && cat ${foot_tmp_file}"
rm ${foot_tmp_file}
```

View file

@ -18,6 +18,7 @@ cd "${blddir}"
"${blddir}"/footclient --version
"${blddir}"/foot \
--config=/dev/null \
--override tweak.grapheme-shaping=no \
--term=xterm \
sh -c "
set -eux