mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-05 04:06:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

term: limit app-id to 2048 characters

Browse source 
Unsure if the protocol imposes a limit (haven't found any
documentation), or if the issue is in the libwayland implementation,
or wlroots (triggers in at least sway+river).

The issue is that setting a too long app-id causes the
compositor (river at least) to peg the CPU at 100%, and stop sending
e.g. frame callbacks to foot.

Closes #1897
This commit is contained in:
Daniel Eklöf 2025-01-02 08:58:48 +01:00
parent f8ebe985a8
commit c7ab7b3539
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
CHANGELOG.md
View file

@ -59,6 +59,13 @@
## Unreleased
### Added
### Changed
* Runtime changes to the app-id (OSC-176) now limits the app-id string
to 2048 characters ([#1897][1897]).
[1897]: https://codeberg.org/dnkl/foot/issues/1897
### Deprecated
### Removed
### Fixed

15
terminal.c
View file

@ -3588,8 +3588,10 @@ term_set_app_id(struct terminal *term, const char *app_id)
{
if (app_id != NULL && *app_id == '\0')
app_id = NULL;
if (term->app_id == NULL && app_id == NULL)
return;
if (term->app_id != NULL && app_id != NULL && streq(term->app_id, app_id))
return;
@ -3604,6 +3606,19 @@ term_set_app_id(struct terminal *term, const char *app_id)
} else {
term->app_id = NULL;
}
const size_t length = strlen(app_id);
if (length > 2048) {
/*
* Not sure if there's a limit in the protocol, or the
* libwayland implementation, or e.g. wlroots, but too long
* app-id's (not e.g. title) causes at least river and sway to
* peg the CPU at 100%, and stop sending e.g. frame callbacks.
*
*/
term->app_id[2048] = '\0';
}
render_refresh_app_id(term);
render_refresh_icon(term);
}