config: error out on empty key- or mouse binding

Closes #851
This commit is contained in:
Daniel Eklöf 2021-12-18 20:39:08 +01:00
parent 0b9cb6bd2f
commit c076f03dc4
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 8 additions and 0 deletions

View file

@ -62,6 +62,8 @@
CSI codes in the Kitty keyboard protocol.
* Assertion in `shm.c:buffer_release()`
(https://codeberg.org/dnkl/foot/issues/844).
* Crash when setting a key- or mouse binding to the empty string
(https://codeberg.org/dnkl/foot/issues/851).
### Security

View file

@ -1726,6 +1726,12 @@ value_to_key_combos(struct context *ctx, int action, struct argv *argv,
}
if (idx == 0) {
LOG_CONTEXTUAL_ERR(
"empty binding not allowed (set to 'none' to unmap)");
goto err;
}
remove_from_key_bindings_list(bindings, action, argv);
bindings->arr = xrealloc(