mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-05 04:06:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

term: check visual-focus, not kbd-focus when enabling/disabling cursor blink

Browse source 
term_cursor_blink_update() is called when the visual focus changes
state (i.e. when our top-level surface is activated de-activated).

Checking keyboard focus worked on Sway, but on e.g. GNOME, the order
in which keyboard focus and visual focus are updated is different, and
we ended up either making the cursor invisible, or visible, but not
blinking, when changing focus back to the window.

Closes #686
This commit is contained in:
Daniel Eklöf 2021-08-17 18:31:42 +02:00
parent 9d1de74795
commit b4402a6aa5
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -93,6 +93,9 @@
freeze when closing a footclient window.
* Underlying cell content showing through in the left-most column of
sixels.
* Blinking cursor stops blinking, or becoming invisible, when
switching focus from, and then back to a terminal window on GNOME
(https://codeberg.org/dnkl/foot/issues/686).
### Security

4
terminal.c
View file

@ -2456,11 +2456,11 @@ void
term_cursor_blink_update(struct terminal *term)
{
bool enable = term->cursor_blink.decset || term->cursor_blink.deccsusr;
bool activate = !term->shutdown.in_progress && enable && term->kbd_focus;
bool activate = !term->shutdown.in_progress && enable && term->visual_focus;
LOG_DBG("decset=%d, deccsrusr=%d, focus=%d, shutting-down=%d, enable=%d, activate=%d",
term->cursor_blink.decset, term->cursor_blink.deccsusr,
term->kbd_focus, term->shutdown.in_progress,
term->visual_focus, term->shutdown.in_progress,
enable, activate);
if (activate && term->cursor_blink.fd < 0) {