mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-07 04:06:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

quirks: add KDE quirk: surface must be damaged *after* being attached

Browse source 
KDE resets all surface damage when a buffer is attached. Add a quirk
that adds a full-buffer damage to the surface. This quirk is intended
to be called after attaching a buffer to a surface.
This commit is contained in:
Daniel Eklöf 2020-03-24 17:44:17 +01:00
parent 3a04061847
commit b42709525c
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 43 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

37
quirks.c
View file

@ -2,6 +2,7 @@
#include <stdlib.h>
#include <stdbool.h>
#include <string.h>
#define LOG_MODULE "quirks"
#define LOG_ENABLE_DBG 0
@ -12,19 +13,6 @@
static bool
is_weston(void)
{
/*
* On weston (8.0), synchronized subsurfaces aren't updated
* correctly.
* They appear to render once, but after that, updates are
* sporadic. Sometimes they update, most of the time they
* don't.
*
* Adding explicit parent surface commits right after the
* subsurface commit doesn't help (and would be useless anyway,
* since it would defeat the purpose of having the subsurface
* synchronized in the first place).
*/
static bool is_weston = false;
static bool initialized = false;
@ -79,3 +67,26 @@ quirk_weston_csd_off(struct terminal *term)
for (int i = 0; i < ALEN(term->window->csd.surface); i++)
quirk_weston_subsurface_desync_off(term->window->csd.sub_surface[i]);
}
void
quirk_kde_damage_before_attach(struct wl_surface *surface)
{
static bool is_kde = false;
static bool initialized = false;
if (!initialized) {
initialized = true;
const char *cur_desktop = getenv("XDG_CURRENT_DESKTOP");
if (cur_desktop != NULL)
is_kde = strcasestr(cur_desktop, "kde") != NULL;
if (is_kde)
LOG_WARN("applying wl_surface_damage_buffer() workaround for KDE");
}
if (!is_kde)
return;
wl_surface_damage_buffer(surface, 0, 0, INT32_MAX, INT32_MAX);
}

19
quirks.h
View file

@ -4,9 +4,28 @@
#include "terminal.h"
/*
* On weston (8.0), synchronized subsurfaces aren't updated correctly.
* They appear to render once, but after that, updates are
* sporadic. Sometimes they update, most of the time they don't.
*
* Adding explicit parent surface commits right after the subsurface
* commit doesn't help (and would be useless anyway, since it would
* defeat the purpose of having the subsurface synchronized in the
* first place).
*/
void quirk_weston_subsurface_desync_on(struct wl_subsurface *sub);
void quirk_weston_subsurface_desync_off(struct wl_subsurface *sub);
/* Shortcuts to call desync_{on,off} on all CSD subsurfaces */
void quirk_weston_csd_on(struct terminal *term);
void quirk_weston_csd_off(struct terminal *term);
/*
* KDE discards all previous damage when a buffer is attached to a
* surface. Thus, if you have recorded damage before you call
* wl_surface_attach(), call this function to record a full buffer
* damage.
*/
void quirk_kde_damage_before_attach(struct wl_surface *surface);