mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-03-31 07:11:09 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

render: change baseline calculation, to center it within the line

Browse source 
Before this patch, fonts were anchored to the top of the line. With
this patch, it is instead centered.

Closes #1302
This commit is contained in:
Daniel Eklöf 2023-07-21 08:17:32 +02:00
parent 098f0aafd4
commit b3255465f1
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -59,10 +59,13 @@
`footclient` now tries `$XDG_RUNTIME_DIR/foot.sock`, then `footclient` now tries `$XDG_RUNTIME_DIR/foot.sock`, then
`/tmp/foot.sock`, even if `$WAYLAND_DISPLAY` and/or `/tmp/foot.sock`, even if `$WAYLAND_DISPLAY` and/or
`$XDG_RUNTIME_DIR` are defined ([#1281][1281]). `$XDG_RUNTIME_DIR` are defined ([#1281][1281]).
* Font baseline calculation: try to center the text within the line,
instead of anchoring it at the top ([#1302][1302]).
[starlight-v4]: https://github.com/CosmicToast/starlight/blob/v4/CHANGELOG.md#v4 [starlight-v4]: https://github.com/CosmicToast/starlight/blob/v4/CHANGELOG.md#v4
[1416]: https://codeberg.org/dnkl/foot/issues/1416 [1416]: https://codeberg.org/dnkl/foot/issues/1416
[1281]: https://codeberg.org/dnkl/foot/pulls/1281 [1281]: https://codeberg.org/dnkl/foot/pulls/1281
[1302]: https://codeberg.org/dnkl/foot/issues/1302
### Deprecated ### Deprecated

7
render.c
View file

@ -305,7 +305,12 @@ color_brighten(const struct terminal *term, uint32_t color)
static inline int static inline int
font_baseline(const struct terminal *term) font_baseline(const struct terminal *term)
{ {
return term->font_y_ofs + term->fonts[0]->ascent; const struct fcft_font *font = term->fonts[0];
const int line_height = term->cell_height;
const int font_height = font->ascent + font->descent;
const int glyph_top_y = round((line_height - font_height) / 2.);
return term->font_y_ofs + glyph_top_y + font->ascent;
} }
static void static void