From b22322bfd104949b93d1df22ff36689747917448 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Mon, 15 Nov 2021 19:22:06 +0100
Subject: [PATCH] =?UTF-8?q?config:=20letter-spacing:=20add=20missing=20?=
 =?UTF-8?q?=E2=80=98return=E2=80=99?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The missing return caused us to fall through to the bottom of the
function, where we ended with an error message:

  [main].letter-spacing: 0: not a valid option: letter-spacing

Closes #795
---
 CHANGELOG.md | 5 +++++
 config.c     | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ca4d8a7d..b65f0b63 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -46,6 +46,11 @@
 ### Deprecated
 ### Removed
 ### Fixed
+
+* Regression: `letter-spacing` resulting in a “not a valid option”
+  error (https://codeberg.org/dnkl/foot/issues/795).
+
+
 ### Security
 ### Contributors
 
diff --git a/config.c b/config.c
index 905f26d6..2f12e201 100644
--- a/config.c
+++ b/config.c
@@ -956,7 +956,7 @@ parse_section_main(struct context *ctx)
         return value_to_pt_or_px(ctx, &conf->line_height);
 
     else if (strcmp(key, "letter-spacing") == 0)
-        value_to_pt_or_px(ctx, &conf->letter_spacing);
+        return value_to_pt_or_px(ctx, &conf->letter_spacing);
 
     else if (strcmp(key, "horizontal-letter-offset") == 0)
         return value_to_pt_or_px(ctx, &conf->horizontal_letter_offset);