mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-27 01:40:16 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

term: set_app_id(): app_id may be NULL, in which case we can't do strlen()

Browse source 
Closes #1963
This commit is contained in:
Daniel Eklöf 2025-02-18 15:09:23 +01:00
parent ba5f4abdd4
commit 9f9ffa9434
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -116,6 +116,8 @@
ZERO WIDTH SPACE) being ignored (discarded and never stored in the
grid) ([#1960][1960]).
* `--server=<FD>` not working on FreeBSD ([#1956][1956]).
* Crash when resetting the terminal and an application had previously
set a custom app ID ([#1963][1963])
[1918]: https://codeberg.org/dnkl/foot/issues/1918
[1929]: https://codeberg.org/dnkl/foot/issues/1929
@ -123,6 +125,7 @@
[1954]: https://codeberg.org/dnkl/foot/issues/1954
[1960]: https://codeberg.org/dnkl/foot/issues/1960
[1956]: https://codeberg.org/dnkl/foot/issues/1956
[1963]: https://codeberg.org/dnkl/foot/issues/1963
### Security

2
terminal.c
View file

@ -3620,7 +3620,7 @@ term_set_app_id(struct terminal *term, const char *app_id)
term->app_id = NULL;
}
const size_t length = strlen(app_id);
const size_t length = app_id != NULL ? strlen(app_id) : 0;
if (length > 2048) {
/*
* Not sure if there's a limit in the protocol, or the