mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-03-17 05:33:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

csi: fix sub-parameter versions of 38/48 SGR escapes

Browse source 
Well this is embarrassing; the sub-parameter versions of the 38/48 SGR
escapes all required an extra ‘:2’ that wasn’t supposed to be there,
causing all the other sub-parameters to be shifted one step to the
right.

That is, foot expected e.g. 38:2:2:r:g:b, or 38:2:5:idx when the
correct sequences are 38:2:cs:r:g:b and 38:5:idx.

I.e. I mixed up the color-space ID (cs) of 38:2 with *type* of color:
RGB or indexed.

In addition to fixing this, this patch also adds support for a
“bastard” version of the sub-parameter based RGB escapes, where the
color-space identifier has been left out: e.g. 38:2:r:g:b. This
sequence is invalid, but applications tend to “forget” the color-space
ID...
This commit is contained in:
Daniel Eklöf 2020-12-12 20:50:43 +01:00
parent ff96ce1e91
commit 9f321e6030
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
3 changed files with 82 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

6
CHANGELOG.md
View file

@ -107,6 +107,10 @@ means foot can be PGO:d in e.g. sandboxed build scripts. See
has been used to enable blinking. **cursor.blink** in `foot.ini`
controls the default state of `CSI Ps SP q`
(https://codeberg.org/dnkl/foot/issues/218).
* The sub-parameter versions of the SGR RGB color escapes (e.g
`\E[38:2...m`) can now be used _without_ the color space ID
parameter.
### Deprecated
### Removed
@ -125,6 +129,8 @@ means foot can be PGO:d in e.g. sandboxed build scripts. See
attributes and charset configuration, just like `\E7`+`\E8`.
* Report mouse motion events to the client application also while
dragging the cursor outside the grid.
* Parsing of the sub-parameter versions of indexed SGR color escapes
(e.g. `\E[38:5...m`)
### Security