From 90ce4f3008a7c7f01dcdee4504b9c512c96a41d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Mon, 26 Sep 2022 19:09:33 +0200
Subject: [PATCH] main/client: use $PWD for cwd, when $PWD is valid
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If $PWD is set, and its resolved path matches the *actual* working
directory, use $PWD for cwd when instantiating the terminal.

This makes a difference when $PWD refers to a symlink; before this
patch, we’d instantiate the terminal in the *resolved* path. Now it’ll
use the symlink instead.
---
 client.c | 22 ++++++++++++++++++++++
 main.c   | 22 ++++++++++++++++++++++
 2 files changed, 44 insertions(+)

diff --git a/client.c b/client.c
index 7624e7db..2a802d16 100644
--- a/client.c
+++ b/client.c
@@ -408,6 +408,28 @@ main(int argc, char *const *argv)
         cwd = _cwd;
     }
 
+    const char *pwd = getenv("PWD");
+    if (pwd != NULL) {
+        char *resolved_path_cwd = realpath(cwd, NULL);
+        char *resolved_path_pwd = realpath(pwd, NULL);
+
+        if (resolved_path_cwd != NULL &&
+            resolved_path_pwd != NULL &&
+            strcmp(resolved_path_cwd, resolved_path_pwd) == 0)
+        {
+            /*
+             * The resolved path of $PWD matches the resolved path of
+             * the *actual* working directory - use $PWD.
+             *
+             * This makes a difference when $PWD refers to a symlink.
+             */
+            cwd = pwd;
+        }
+
+        free(resolved_path_cwd);
+        free(resolved_path_pwd);
+    }
+
     if (client_environment) {
         for (char **e = environ; *e != NULL; e++) {
             if (!push_string(&envp, *e, &total_len))
diff --git a/main.c b/main.c
index 4617a3c7..a3ae579d 100644
--- a/main.c
+++ b/main.c
@@ -594,6 +594,28 @@ main(int argc, char *const *argv)
         cwd = _cwd;
     }
 
+    const char *pwd = getenv("PWD");
+    if (pwd != NULL) {
+        char *resolved_path_cwd = realpath(cwd, NULL);
+        char *resolved_path_pwd = realpath(pwd, NULL);
+
+        if (resolved_path_cwd != NULL &&
+            resolved_path_pwd != NULL &&
+            strcmp(resolved_path_cwd, resolved_path_pwd) == 0)
+        {
+            /*
+             * The resolved path of $PWD matches the resolved path of
+             * the *actual* working directory - use $PWD.
+             *
+             * This makes a difference when $PWD refers to a symlink.
+             */
+            cwd = pwd;
+        }
+
+        free(resolved_path_cwd);
+        free(resolved_path_pwd);
+    }
+
     shm_set_max_pool_size(conf.tweak.max_shm_pool_size);
 
     if ((fdm = fdm_init()) == NULL)