mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-04-01 07:15:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

selection: performance: check for < 0 or >= 0 instead of == -1

Browse source
This commit is contained in:
Daniel Eklöf 2020-05-19 18:51:30 +02:00
parent 08588cd0fc
commit 8ad3b9c172
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
selection.c
View file

@ -36,7 +36,7 @@ selection_on_rows(const struct terminal *term, int row_start, int row_end)
term->selection.start.row, term->selection.end.row, term->selection.start.row, term->selection.end.row,
row_start, row_end, term->grid->offset); row_start, row_end, term->grid->offset);
if (term->selection.end.row == -1) if (term->selection.end.row < 0)
return false; return false;
assert(term->selection.start.row != -1); assert(term->selection.start.row != -1);
@ -203,7 +203,7 @@ min_bufsize_for_extraction(const struct terminal *term)
return 0; return 0;
case SELECTION_NORMAL: case SELECTION_NORMAL:
if (term->selection.end.row == -1) if (term->selection.end.row < 0)
return 0; return 0;
assert(term->selection.start.row != -1); assert(term->selection.start.row != -1);
@ -406,7 +406,7 @@ selection_modify(struct terminal *term, struct coord start, struct coord end)
/* Premark all cells that *will* be selected */ /* Premark all cells that *will* be selected */
foreach_selected(term, start, end, &premark_selected, NULL); foreach_selected(term, start, end, &premark_selected, NULL);
if (term->selection.end.row != -1) { if (term->selection.end.row >= 0) {
/* Unmark previous selection, ignoring cells that are part of /* Unmark previous selection, ignoring cells that are part of
* the new selection */ * the new selection */
foreach_selected(term, term->selection.start, term->selection.end, foreach_selected(term, term->selection.start, term->selection.end,
@ -424,7 +424,7 @@ selection_modify(struct terminal *term, struct coord start, struct coord end)
void void
selection_update(struct terminal *term, int col, int row) selection_update(struct terminal *term, int col, int row)
{ {
if (term->selection.start.row == -1) if (term->selection.start.row < 0)
return; return;
LOG_DBG("selection updated: start = %d,%d, end = %d,%d -> %d, %d", LOG_DBG("selection updated: start = %d,%d, end = %d,%d -> %d, %d",
@ -441,7 +441,7 @@ selection_update(struct terminal *term, int col, int row)
void void
selection_dirty_cells(struct terminal *term) selection_dirty_cells(struct terminal *term)
{ {
if (term->selection.start.row == -1 || term->selection.end.row == -1) if (term->selection.start.row < 0 || term->selection.end.row < 0)
return; return;
foreach_selected( foreach_selected(
@ -566,7 +566,7 @@ selection_extend_block(struct terminal *term, int col, int row, uint32_t serial)
void void
selection_extend(struct terminal *term, int col, int row, uint32_t serial) selection_extend(struct terminal *term, int col, int row, uint32_t serial)
{ {
if (term->selection.start.row == -1 || term->selection.end.row == -1) { if (term->selection.start.row < 0 || term->selection.end.row < 0) {
/* No existing selection */ /* No existing selection */
return; return;
} }
@ -602,7 +602,7 @@ static const struct zwp_primary_selection_source_v1_listener primary_selection_s
void void
selection_finalize(struct terminal *term, uint32_t serial) selection_finalize(struct terminal *term, uint32_t serial)
{ {
if (term->selection.start.row == -1 || term->selection.end.row == -1) if (term->selection.start.row < 0 || term->selection.end.row < 0)
return; return;
assert(term->selection.start.row != -1); assert(term->selection.start.row != -1);
@ -628,7 +628,7 @@ selection_cancel(struct terminal *term)
term->selection.start.row, term->selection.start.col, term->selection.start.row, term->selection.start.col,
term->selection.end.row, term->selection.end.col); term->selection.end.row, term->selection.end.col);
if (term->selection.start.row != -1 && term->selection.end.row != -1) { if (term->selection.start.row >= 0 && term->selection.end.row >= 0) {
foreach_selected( foreach_selected(
term, term->selection.start, term->selection.end, term, term->selection.start, term->selection.end,
&unmark_selected, NULL); &unmark_selected, NULL);
@ -961,7 +961,7 @@ text_to_clipboard(struct terminal *term, char *text, uint32_t serial)
void void
selection_to_clipboard(struct terminal *term, uint32_t serial) selection_to_clipboard(struct terminal *term, uint32_t serial)
{ {
if (term->selection.start.row == -1 || term->selection.end.row == -1) if (term->selection.start.row < 0 || term->selection.end.row < 0)
return; return;
/* Get selection as a string */ /* Get selection as a string */