mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-05 04:06:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

dcs: decrqss: add note about Ps in the reply

Browse source
This commit is contained in:
Daniel Eklöf 2022-01-13 15:46:29 +01:00
parent a8681ea440
commit 7243b094b7
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
dcs.c
View file

@ -219,6 +219,17 @@ decrqss(struct terminal *term)
const uint8_t *query = term->vt.dcs.data; const uint8_t *query = term->vt.dcs.data;
const size_t n = term->vt.dcs.idx; const size_t n = term->vt.dcs.idx;
/*
* A note on the Ps parameter in the reply: many DEC manual
* instances (e.g. https://vt100.net/docs/vt510-rm/DECRPSS) claim
* that 0 means “request is valid”, and 1 means “request is
* invalid”.
*
* However, this appears to be a typo; actual hardware inverts the
* response (as does XTerm and mlterm):
* https://github.com/hackerb9/vt340test/issues/13
*/
if (memcmp(query, "r", n) == 0) { if (memcmp(query, "r", n) == 0) {
/* DECSTBM - Set Top and Bottom Margins */ /* DECSTBM - Set Top and Bottom Margins */
char reply[64]; char reply[64];