From 70b324b24c86473a99528feb6f1f91ca70e11a02 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Thu, 24 Apr 2025 08:23:56 +0200
Subject: [PATCH] term: ignore LTR+RTL markers  (U+200E + U+200F)

Foot doesn't implement RTL, and explicit LTR markers is neither
needed, nor used in anyway. In fact, they cause issues with font
lookup, as fcft often fails to find the marker codepoint in the
primary font, causing a fallback font to be used instead.

Closes #2049
---
 CHANGELOG.md | 9 +++++++++
 terminal.c   | 8 ++++++++
 2 files changed, 17 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 35669f03..62dc7e03 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -63,6 +63,13 @@
 ## Unreleased
 ### Added
 ### Changed
+
+* Left-to-right and right-to-left markers (U+200E and U+200F) are now
+  ignored ([#2049][2049]).
+
+[2049]: https://codeberg.org/dnkl/foot/issues/2049
+
+
 ### Deprecated
 ### Removed
 ### Fixed
@@ -73,6 +80,8 @@
   codepoints ([#2039][2039]).
 * Keyboard modifiers not being reset on keyboard leave events
   ([#2034][2034]).
+* Last character in a `remind` calendar event being in the wrong font
+  and color ([#2049][2049]).
 
 [2039]: https://codeberg.org/dnkl/foot/issues/2039
 [2034]: https://codeberg.org/dnkl/foot/issues/2034
diff --git a/terminal.c b/terminal.c
index ae1adb1a..59c39760 100644
--- a/terminal.c
+++ b/terminal.c
@@ -4156,6 +4156,14 @@ term_process_and_print_non_ascii(struct terminal *term, char32_t wc)
         (grapheme_clustering ||
          (!grapheme_clustering && width == 0 && wc >= 0x300)))
     {
+        if (unlikely(wc == 0x200e || wc == 0x200f)) {
+            /*
+             * Ignore left-to-right and right-to-left markers
+             * see https://codeberg.org/dnkl/foot/issues/2049
+             */
+            return;
+        }
+
         int col = term->grid->cursor.point.col;
         if (!term->grid->cursor.lcf)
             col--;