From 6fd4f6000b493c16c778cb1bca6c8d2d9f3ec988 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Fri, 18 Oct 2019 19:50:48 +0200
Subject: [PATCH] font: glyph_for_wchar(): ensure glyph->valid == false, in
 *all* error cases

---
 font.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/font.c b/font.c
index d19925a7..4b1be833 100644
--- a/font.c
+++ b/font.c
@@ -324,6 +324,11 @@ hash_index(wchar_t wc)
 static bool
 glyph_for_wchar(const struct font *font, wchar_t wc, struct glyph *glyph)
 {
+    *glyph = (struct glyph){
+        .wc = wc,
+        .valid = false,
+    };
+
     /*
      * LCD filter is per library instance. Thus we need to re-set it
      * every time...
@@ -552,10 +557,7 @@ glyph_for_wchar(const struct font *font, wchar_t wc, struct glyph *glyph)
     return true;
 
 err:
-    *glyph = (struct glyph){
-        .wc = wc,
-        .valid = false,
-    };
+    assert(!glyph->valid);
     return false;
 }