mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-08 10:06:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

osc: kitty notifications: ignore invalid IDs

Browse source 
Notification IDs must only use characters from [a-zA-Z0-9_-+.]

    Terminals **must** sanitize ids received from client programs
    before sending them back in responses, to mitigate input injection
    based attacks. That is, they must either reject ids containing
    characters not from the above set, or remove bad characters when
    reading ids sent to them.

Foot implements the first: reject IDs containing characters not from
the above set.
This commit is contained in:
Daniel Eklöf 2024-08-03 11:05:58 +02:00
parent 62b0b65d47
commit 6b72108ee2
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
1 changed files with 33 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

36
osc.c
View file

@ -564,6 +564,33 @@ osc_notify(struct terminal *term, char *string)
});
}
IGNORE_WARNING("-Wpedantic")
static bool
verify_kitty_id_is_valid(const char *id)
{
const size_t len = strlen(id);
for (size_t i = 0; i < len; i++) {
switch (id[i]) {
case 'a' ... 'z':
case 'A' ... 'Z':
case '0' ... '9':
case '_':
case '-':
case '+':
case '.':
break;
default:
return false;
}
}
return true;
}
UNIGNORE_WARNINGS
static void
kitty_notification(struct terminal *term, char *string)
{
@ -672,8 +699,11 @@ kitty_notification(struct terminal *term, char *string)
case 'i':
/* id */
free(id);
id = xstrdup(value);
if (verify_kitty_id_is_valid(value)) {
free(id);
id = xstrdup(value);
} else
LOG_WARN("OSC-99: ignoring invalid 'i' identifier");
break;
case 'p':
@ -963,7 +993,7 @@ kitty_notification(struct terminal *term, char *string)
tll_push_back(notif->actions, xstrdup(button));
}
}
break;
}
}