osc: notify: fix crash with no message

Closes #1866
This commit is contained in:
Jack Wilsdon 2024-10-28 17:52:09 +00:00 committed by Daniel Eklöf
parent 813b514f63
commit 689549bb1f
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 7 additions and 2 deletions

View file

@ -473,7 +473,8 @@ notify_notify(struct terminal *term, struct notification *notif)
"urgency", "muted", "sound-name", "expire-time", "replace-id", "urgency", "muted", "sound-name", "expire-time", "replace-id",
"action-argument"}, "action-argument"},
(const char *[]){ (const char *[]){
app_id, term->window_title, icon_name_or_path, title, body, app_id, term->window_title, icon_name_or_path, title,
body != NULL ? body : "",
notif->category != NULL ? notif->category : "", urgency_str, notif->category != NULL ? notif->category : "", urgency_str,
notif->muted ? "true" : "false", notif->muted ? "true" : "false",
notif->sound_name != NULL ? notif->sound_name : "", notif->sound_name != NULL ? notif->sound_name : "",

6
osc.c
View file

@ -557,9 +557,13 @@ osc_notify(struct terminal *term, char *string)
return; return;
} }
char *msgdup = NULL;
if (msg != NULL)
msgdup = xstrdup(msg);
notify_notify(term, &(struct notification){ notify_notify(term, &(struct notification){
.title = xstrdup(title), .title = xstrdup(title),
.body = xstrdup(msg), .body = msgdup,
.expire_time = -1, .expire_time = -1,
.focus = true, .focus = true,
}); });