mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-04 04:06:06 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

grid: uri_range_erase: walk the ranges backwards

Browse source 
This way, ranges are deleted last-to-first, thus avoiding memmoving
multiple ranges over and over again when erasing e.g. a full line.
This commit is contained in:
Daniel Eklöf 2021-11-28 10:56:32 +01:00
parent 747da83c76
commit 66b8c92c30
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
grid.c
View file

@ -1143,19 +1143,18 @@ grid_row_uri_range_erase(struct row *row, int start, int end)
struct row_data *extra = row->extra;
/* Split up, or remove, URI ranges affected by the erase */
for (ssize_t i = 0; i < extra->uri_ranges.count; i++) {
for (ssize_t i = (ssize_t)extra->uri_ranges.count - 1; i >= 0; i--) {
struct row_uri_range *old = &extra->uri_ranges.v[i];
if (old->end < start)
continue;
return;
if (old->start > end)
return;
continue;
if (start <= old->start && end >= old->end) {
/* Erase range covers URI completely - remove it */
uri_range_delete(extra, i);
i--;
}
else if (start > old->start && end < old->end) {
@ -1170,13 +1169,13 @@ grid_row_uri_range_erase(struct row *row, int start, int end)
/* Erase range erases the head of the URI */
xassert(start <= old->start);
old->start = end + 1;
return; /* There can be no more overlapping URIs */
}
else if (start <= old->end && end >= old->end) {
/* Erase range erases the tail of the URI */
xassert(end >= old->end);
old->end = start - 1;
return; /* There can be no more overlapping URIs */
}
}
}