From 60a6991c2579f2b390b95e764d8bedc45fab3962 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Fri, 5 Apr 2024 16:32:02 +0200 Subject: [PATCH] slave: ignore SIGHUP, instead of resetting it to DFL This aligns foot's behavior with e.g. XTerm, when running 'foot script.sh', where script.sh is: #!/usr/bin/bash sleep 2s exec setsid --fork sh -c 'sleep 5; notify-send test' Before this patch, 'notify-send' never ran. With this patch it does. I don't, yet, fully understand what's happening here, or what's "more" correct. See #1666 --- slave.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/slave.c b/slave.c index bcd864e1..74e33833 100644 --- a/slave.c +++ b/slave.c @@ -406,8 +406,11 @@ slave_spawn(int ptmx, int argc, const char *cwd, char *const *argv, sigset_t mask; sigemptyset(&mask); + struct sigaction ign = {.sa_handler = SIG_IGN}; + sigemptyset(&ign.sa_mask); + if (sigprocmask(SIG_SETMASK, &mask, NULL) < 0 || - sigaction(SIGHUP, &dfl, NULL) < 0 || + sigaction(SIGHUP, &ign, NULL) < 0 || sigaction(SIGPIPE, &dfl, NULL) < 0) { const int errno_copy = errno;