From 55a4e59ef96227f23fa00e8c772804f67601567a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Tue, 23 Jul 2024 15:30:01 +0200 Subject: [PATCH] notify: if there's a symbolic icon name, use it even if there's no graphical ID set. In other words, if there *is* a graphical ID, use the icon cache. Only if there is no graphical ID in the notification request do we fallback to the symbolic name. This means no icon will be displayed if there's no matching icon in the cache. Some examples. You can either pre-load the cache (with inline PNG data, a symbolic name, or both): printf '\e]99;g=123:n=firefox:p=icon:e=1;\e\\' printf '\e]99;g=123;this is a notification\e\\' or printf '\e]99;n=firefox;this is a notification\e\\' --- notify.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/notify.c b/notify.c index b16b941b..4261268d 100644 --- a/notify.c +++ b/notify.c @@ -187,6 +187,8 @@ notify_notify(struct terminal *term, struct notification *notif) break; } } + } else if (notif->icon_symbolic_name != NULL) { + icon_name_or_path = notif->icon_symbolic_name; } bool track_notification = notif->focus || notif->report;