mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-02-15 22:05:24 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

render: dirty all multi-cursor cells *after* rendering a frame

Browse source 
This ensures they're re-rendered the next frame, and fixes an issue
were multi-cursors weren't erased when scrolled. That is, they
scrolled with the content, *and* was re-drawn at the correct (fixed)
location they were scrolled away from.

Since multi-cursors shouldn't scroll with the content, they need to be
erased when the content is scrolled.
This commit is contained in:
Daniel Eklöf 2025-08-31 09:29:27 +02:00
parent 4907c5d08a
commit 4f89c461b1
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
1 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

26
render.c
View file

@ -3703,6 +3703,32 @@ grid_render(struct terminal *term)
pixman_region32_fini(&damage);
if (unlikely(term->multi_cursor.shapes != NULL)) {
/*
* WIP: dirty all multi-cursors again, to ensure they're
* re-rendered the next frame. This is needed to properly
* _erase_ multi-cursors that have been scrolled (the cursors
* don't scroll with the content, but stay fixed)
*/
int rect_count = 0;
const pixman_box32_t *boxes = pixman_region32_rectangles(&term->multi_cursor.active, &rect_count);
for (int i = 0; i < rect_count; i++) {
const pixman_box32_t *box = &boxes[i];
for (int r = box->y1; r < box->y2; r++) {
struct row *row = grid_row(term->grid, r);
xassert(row != NULL);
row->dirty = true;
for (int c = box->x1; c < box->x2; c++)
row->cells[c].attrs.clean = false;
}
}
}
render_overlay(term);
render_ime_preedit(term, buf);
render_scrollback_position(term);