mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-05-30 21:38:03 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

selection: do not copy empty text

Browse source 
Copy-on-select (configured with 'selection-target') may accidentally
clear the clipboard, if the user drags the mouse a little bit when
clicking inside a terminal window.

Now we only copy if there is actual text being selected.

Closes #2327
This commit is contained in:
CismonX 2026-05-21 02:38:16 +08:00 • committed by Daniel Eklöf
parent b18d8aa2f1
commit 4bf60d0fbc
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG.md
View file

@ -81,9 +81,11 @@
content ([#2353][2353]). content ([#2353][2353]).
* DECCRA not clamping or verifying the destination rectangle * DECCRA not clamping or verifying the destination rectangle
([#2352][2352]). ([#2352][2352]).
* Empty selection clearing the clipboard ([#2327][2327]).
[2353]: https://codeberg.org/dnkl/foot/issues/2353 [2353]: https://codeberg.org/dnkl/foot/issues/2353
[2352]: https://codeberg.org/dnkl/foot/issues/2352 [2352]: https://codeberg.org/dnkl/foot/issues/2352
[2327]: https://codeberg.org/dnkl/foot/issues/2327
### Security ### Security

6
selection.c
View file

@ -1948,6 +1948,9 @@ static const struct zwp_primary_selection_source_v1_listener primary_selection_s
bool bool
text_to_clipboard(struct seat *seat, struct terminal *term, char *text, uint32_t serial) text_to_clipboard(struct seat *seat, struct terminal *term, char *text, uint32_t serial)
{ {
if (text == NULL || text[0] == '\0')
return false;
xassert(serial != 0); xassert(serial != 0);
struct wl_clipboard *clipboard = &seat->clipboard; struct wl_clipboard *clipboard = &seat->clipboard;
@ -2418,6 +2421,9 @@ selection_from_clipboard(struct seat *seat, struct terminal *term, uint32_t seri
bool bool
text_to_primary(struct seat *seat, struct terminal *term, char *text, uint32_t serial) text_to_primary(struct seat *seat, struct terminal *term, char *text, uint32_t serial)
{ {
if (text == NULL || text[0] == '\0')
return false;
if (term->wl->primary_selection_device_manager == NULL) if (term->wl->primary_selection_device_manager == NULL)
return false; return false;