From 572b7d0f969b3627012758298afa1810e66ff55d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Wed, 11 Aug 2021 18:30:14 +0200 Subject: [PATCH 1/4] terminfo: remove km/smm/rmm MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit By default, foot prefixes Alt- combos with ESC, instead of setting the 8:th “meta” bit. In this mode, smm/rmm has no effect. This mode _can_ be disabled, by resetting private mode 1036. However, the terminfo should reflect the terminal’s *default* behavior. --- foot.info | 3 --- 1 file changed, 3 deletions(-) diff --git a/foot.info b/foot.info index 1f8d27ab..d50cec75 100644 --- a/foot.info +++ b/foot.info @@ -17,7 +17,6 @@ foot+base|foot base fragment, bw, ccc, hs, - km, mir, msgr, npc, @@ -250,7 +249,6 @@ foot+base|foot base fragment, rmcup=\E[?1049l\E[23;0;0t, rmir=\E[4l, rmkx=\E[?1l\E>, - rmm=\E[?1034l, rmso=\E[27m, rmul=\E[24m, rmxx=\E[29m, @@ -267,7 +265,6 @@ foot+base|foot base fragment, smcup=\E[?1049h\E[22;0;0t, smir=\E[4h, smkx=\E[?1h\E=, - smm=\E[?1034h, smso=\E[7m, smul=\E[4m, smxx=\E[9m, From 2ff8f59525b2cc2ad2e65df2033a499bced35e04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Wed, 11 Aug 2021 18:32:10 +0200 Subject: [PATCH 2/4] terminfo: remove keypad key caps (for keypad application mode) The keypad application mode gated by private mode 1035. I.e. by default, there _is_ no keypad application mode in foot. --- foot.info | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/foot.info b/foot.info index d50cec75..30e9e3de 100644 --- a/foot.info +++ b/foot.info @@ -140,16 +140,7 @@ foot+base|foot base fragment, kUP6=\E[1;6A, kUP7=\E[1;7A, kUP=\E[1;2A, - ka1=\EOw, - ka2=\EOx, - ka3=\EOy, - kb1=\EOt, - kb2=\EOu, - kb3=\EOv, kbs=^?, - kc1=\EOq, - kc2=\EOr, - kc3=\EOs, kcbt=\E[Z, kcub1=\EOD, kcud1=\EOB, @@ -157,7 +148,6 @@ foot+base|foot base fragment, kcuu1=\EOA, kdch1=\E[3~, kend=\EOF, - kent=\EOM, kf10=\E[21~, kf11=\E[23~, kf12=\E[24~, @@ -226,14 +216,6 @@ foot+base|foot base fragment, kind=\E[1;2B, kmous=\E[<, knp=\E[6~, - kp5=\EOE, - kpADD=\EOk, - kpCMA=\EOl, - kpDIV=\EOo, - kpDOT=\EOn, - kpMUL=\EOj, - kpSUB=\EOm, - kpZRO=\EOp, kpp=\E[5~, kri=\E[1;2A, oc=\E]104\E\\, From b40aefa50a2578df72b7d1cff5c55308b4ca2bcd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Sat, 14 Aug 2021 21:08:32 +0200 Subject: [PATCH 3/4] changelog: mention km/smm/rmm being removed --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b415d051..c5d06d58 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -65,6 +65,14 @@ ### Deprecated ### Removed + +* `km`/`smm`/`rmm` from terminfo; foot prefixes Alt-key combinations + with `ESC`, and not by setting the 8:th “meta” bit, regardless of + `smm`/`rmm`. While this _can_ be disabled by, resetting private mode + 1036, the terminfo should reflect the **default** behavior + (https://codeberg.org/dnkl/foot/issues/670). + + ### Fixed * Rendering into the right margin area with `tweak.overflowing-glyphs` From f204f09253db10ac54ce6b6c06c2f9cf37e75f4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= Date: Sat, 14 Aug 2021 21:10:47 +0200 Subject: [PATCH 4/4] changelog: mention keypad application mode keys being removed --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c5d06d58..8e78f7aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -71,6 +71,10 @@ `smm`/`rmm`. While this _can_ be disabled by, resetting private mode 1036, the terminfo should reflect the **default** behavior (https://codeberg.org/dnkl/foot/issues/670). +* Keypad application mode keys from terminfo; enabling the keypad + application mode is not enough to make foot emit these sequences - + you also need to disable private mode 1035 + (https://codeberg.org/dnkl/foot/issues/670). ### Fixed