From 3bb953d6983964d0c12c0f4446970fd3b9aea091 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Sun, 17 Oct 2021 16:31:17 +0200
Subject: [PATCH] config: change key binding for toggle-url-visible to
 Control+t
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The default key binding for toggle-url-visible was, before this,
‘t’.

This leads to a collision with the default value of ‘label-letters’,
which includes ‘t’.
---
 CHANGELOG.md       | 2 ++
 config.c           | 2 +-
 doc/foot.ini.5.scd | 5 ++++-
 foot.ini           | 2 +-
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c445a445..bea6ef7d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -49,6 +49,8 @@
   `double-width` to `wcswidth`.
 * INSTALL.md: `--override tweak.grapheme-shaping=no` added to PGO
   command line.
+* url-mode: default key binding for `toggle-url-visible` changed from
+  `t` to `Control+t`.
 
 
 ### Deprecated
diff --git a/config.c b/config.c
index d437b05e..a7b1cf7f 100644
--- a/config.c
+++ b/config.c
@@ -2830,7 +2830,7 @@ add_default_url_bindings(struct config *conf)
         {BIND_ACTION_URL_CANCEL, m_ctrl, XKB_KEY_g},
         {BIND_ACTION_URL_CANCEL, m_ctrl, XKB_KEY_d},
         {BIND_ACTION_URL_CANCEL, m_none, XKB_KEY_Escape},
-        {BIND_ACTION_URL_TOGGLE_URL_ON_JUMP_LABEL, m_none, XKB_KEY_t},
+        {BIND_ACTION_URL_TOGGLE_URL_ON_JUMP_LABEL, m_ctrl, XKB_KEY_t},
     };
 
     conf->bindings.url.count = ALEN(bindings);
diff --git a/doc/foot.ini.5.scd b/doc/foot.ini.5.scd
index e105be62..471cc258 100644
--- a/doc/foot.ini.5.scd
+++ b/doc/foot.ini.5.scd
@@ -773,6 +773,9 @@ scrollback search mode. The syntax is exactly the same as the regular
 This section lets you override the default key bindings used in URL
 mode. The syntax is exactly the same as the regular **key-bindings**.
 
+Be careful; do not use single-letter keys that are also used in
+*[url].label-letters*, as doing so will make some URLs inaccessible.
+
 *cancel*
 	Exits URL mode without opening an URL. Default: _Control+g
 	Control+c Control+d Escape_.
@@ -789,7 +792,7 @@ mode. The syntax is exactly the same as the regular **key-bindings**.
 	This action toggles between showing and hiding the URL on the jump
 	label.
 	
-	Default: _t_.
+	Default: _Control+t_.
 
 
 # SECTION: mouse-bindings
diff --git a/foot.ini b/foot.ini
index 131d970d..f4368e22 100644
--- a/foot.ini
+++ b/foot.ini
@@ -150,7 +150,7 @@
 
 [url-bindings]
 # cancel=Control+g Control+c Control+d Escape
-# toggle-url-visible=t
+# toggle-url-visible=Control+t
 
 [mouse-bindings]
 # primary-paste=BTN_MIDDLE