quirks: sway does not damage surface beneath sub-surface, when unmapped

When unmapping a sub-surface, Sway <= 1.8 does not damage the surface
beneath the sub-surface.

https://github.com/swaywm/sway/issues/6960

The workaround is to manually damage the main surface. Previously,
this was done when exiting scrollback search, and after the ‘flash’
OSC. But other sub-surfaces, that may also be unmapped, did not.

This patch adds a quirk handler that does this, and calls it when:

* Exiting scrollback search
* Ending the ‘flash’ OSC
* Exiting unicode input mode
* Clearing URL labels
* Removing the scrollback position indicator

Closes #1335
This commit is contained in:
Daniel Eklöf 2023-04-25 21:33:45 +02:00
parent 7eea69df89
commit 3b41379be4
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
6 changed files with 43 additions and 11 deletions

View file

@ -66,3 +66,28 @@ quirk_weston_csd_off(struct terminal *term)
for (int i = 0; i < ALEN(term->window->csd.surface); i++)
quirk_weston_subsurface_desync_off(term->window->csd.surface[i].sub);
}
static bool
is_sway(void)
{
static bool is_sway = false;
static bool initialized = false;
if (!initialized) {
initialized = true;
is_sway = getenv("SWAYSOCK") != NULL;
if (is_sway)
LOG_WARN("applying wl_surface_damage_buffer() workaround for Sway");
}
return is_sway;
}
void
quirk_sway_subsurface_unmap(struct terminal *term)
{
if (!is_sway())
return;
wl_surface_damage_buffer(term->window->surface, 0, 0, INT32_MAX, INT32_MAX);
}