mirrors/foot
1
0
Fork 0
mirror of https://codeberg.org/dnkl/foot.git synced 2026-03-14 05:33:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

quirk: remove plasma/kwin quirk

Browse source 
Older version of Plasma/KWin had an issue where buffer damage recorded
before the buffer was attached were ignored. This appears to have been
fixed now.
This commit is contained in:
Daniel Eklöf 2021-05-11 17:39:13 +02:00
parent 04215bac6c
commit 29776dbd1f
No known key found for this signature in database
GPG key ID: 5BBD4992C116573F
4 changed files with 4 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
CHANGELOG.md
View file

@ -78,6 +78,10 @@
* **bell** option in `foot.ini`; set actions in **[bell]** section instead. * **bell** option in `foot.ini`; set actions in **[bell]** section instead.
### Removed ### Removed
* Buffer damage quirk for Plasma/KWin.
### Fixed ### Fixed
* `generate-alt-random-writes.py --sixel` sometimes crashing, * `generate-alt-random-writes.py --sixel` sometimes crashing,

23
quirks.c
View file

@ -66,26 +66,3 @@ quirk_weston_csd_off(struct terminal *term)
for (int i = 0; i < ALEN(term->window->csd.surface); i++) for (int i = 0; i < ALEN(term->window->csd.surface); i++)
quirk_weston_subsurface_desync_off(term->window->csd.surface[i].sub); quirk_weston_subsurface_desync_off(term->window->csd.surface[i].sub);
} }
void
quirk_kde_damage_before_attach(struct wl_surface *surface)
{
static bool is_kde = false;
static bool initialized = false;
if (!initialized) {
initialized = true;
const char *cur_desktop = getenv("XDG_CURRENT_DESKTOP");
if (cur_desktop != NULL)
is_kde = strcasestr(cur_desktop, "kde") != NULL;
if (is_kde)
LOG_WARN("applying wl_surface_damage_buffer() workaround for KDE");
}
if (!is_kde)
return;
wl_surface_damage_buffer(surface, 0, 0, INT32_MAX, INT32_MAX);
}

8
quirks.h
View file

@ -21,11 +21,3 @@ void quirk_weston_subsurface_desync_off(struct wl_subsurface *sub);
/* Shortcuts to call desync_{on,off} on all CSD subsurfaces */ /* Shortcuts to call desync_{on,off} on all CSD subsurfaces */
void quirk_weston_csd_on(struct terminal *term); void quirk_weston_csd_on(struct terminal *term);
void quirk_weston_csd_off(struct terminal *term); void quirk_weston_csd_off(struct terminal *term);
/*
* KDE discards all previous damage when a buffer is attached to a
* surface. Thus, if you have recorded damage before you call
* wl_surface_attach(), call this function to record a full buffer
* damage.
*/
void quirk_kde_damage_before_attach(struct wl_surface *surface);

1
render.c
View file

@ -2443,7 +2443,6 @@ grid_render(struct terminal *term)
xassert(buf->height % term->scale == 0); xassert(buf->height % term->scale == 0);
wl_surface_attach(term->window->surface, buf->wl_buf, 0, 0); wl_surface_attach(term->window->surface, buf->wl_buf, 0, 0);
quirk_kde_damage_before_attach(term->window->surface);
wl_surface_commit(term->window->surface); wl_surface_commit(term->window->surface);
} }