quirk: remove plasma/kwin quirk

Older version of Plasma/KWin had an issue where buffer damage recorded
before the buffer was attached were ignored. This appears to have been
fixed now.

CHANGELOG.md

@@ -78,6 +78,10 @@
 * **bell** option in `foot.ini`; set actions in **[bell]** section instead.
 
 ### Removed
+
+* Buffer damage quirk for Plasma/KWin.
+
+
 ### Fixed
 
 * `generate-alt-random-writes.py --sixel` sometimes crashing,

quirks.c

@@ -66,26 +66,3 @@ quirk_weston_csd_off(struct terminal *term)
     for (int i = 0; i < ALEN(term->window->csd.surface); i++)
         quirk_weston_subsurface_desync_off(term->window->csd.surface[i].sub);
 }
-
-void
-quirk_kde_damage_before_attach(struct wl_surface *surface)
-{
-    static bool is_kde = false;
-    static bool initialized = false;
-
-    if (!initialized) {
-        initialized = true;
-
-        const char *cur_desktop = getenv("XDG_CURRENT_DESKTOP");
-        if (cur_desktop != NULL)
-            is_kde = strcasestr(cur_desktop, "kde") != NULL;
-
-        if (is_kde)
-            LOG_WARN("applying wl_surface_damage_buffer() workaround for KDE");
-    }
-
-    if (!is_kde)
-        return;
-
-    wl_surface_damage_buffer(surface, 0, 0, INT32_MAX, INT32_MAX);
-}

quirks.h

@@ -21,11 +21,3 @@ void quirk_weston_subsurface_desync_off(struct wl_subsurface *sub);
 /* Shortcuts to call desync_{on,off} on all CSD subsurfaces */
 void quirk_weston_csd_on(struct terminal *term);
 void quirk_weston_csd_off(struct terminal *term);
-
-/*
- * KDE discards all previous damage when a buffer is attached to a
- * surface. Thus, if you have recorded damage before you call
- * wl_surface_attach(), call this function to record a full buffer
- * damage.
- */
-void quirk_kde_damage_before_attach(struct wl_surface *surface);

render.c

@@ -2443,7 +2443,6 @@ grid_render(struct terminal *term)
     xassert(buf->height % term->scale == 0);
 
     wl_surface_attach(term->window->surface, buf->wl_buf, 0, 0);
-    quirk_kde_damage_before_attach(term->window->surface);
     wl_surface_commit(term->window->surface);
 }