Commit graph

8 commits

Author SHA1 Message Date
Andreas Persson
65a201fed6 envy24control: fix memory access errors in profiles
Fix two memory errors in the profiles parser: an invalid read and a
"source and destination overlap in strncpy" warning.

When the profiles page is initialized it fetches the profile names from
the profiles file. When a profile wasn't defined in the file, the parser
made invalid reads outside the buffer.

Closes: https://github.com/alsa-project/alsa-tools/pull/34
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
2025-04-09 11:44:37 +02:00
Andreas Persson
52e6481047 envy24control: fix file descriptor leaks in profiles
File descriptors were leaked when "Save active profile" was pressed. Add
the missing calls to close.

Closes: https://github.com/alsa-project/alsa-tools/pull/33
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
2025-04-09 11:44:11 +02:00
Andreas Persson
037ae73ab3 envy24control: fix crash when using system profiles file
envy24control crashed if you tried to start it with -f
/etc/envy24control/profiles.conf.

Closes: https://github.com/alsa-project/alsa-tools/pull/32
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
2025-04-08 15:23:11 +02:00
Jaroslav Kysela
97092591e0 envy24control: fix cast warnings and string array overflows
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
2025-01-26 13:08:20 +01:00
Jaroslav Kysela
38f7504af2 Change FSF address (Franklin Street)
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
2017-11-14 14:47:19 +01:00
Takashi Iwai
afb0fb4f7b Don't compare with a literal
Don't compare a pointer with a string literal.  Use strcmp instead.
2006-10-17 17:34:42 +02:00
Jaroslav Kysela
70fcc4161e <Dirk.Kalis@t-online.de>
fixed profile number range checks
2004-05-18 11:34:07 +00:00
Jaroslav Kysela
d552f0ca37 Added missing files for profile patch 2004-05-16 13:37:31 +00:00