Change the parameters to gtk_adjustment_new to get rid of this runtime
warning from GTK:
GtkSpinButton: setting an adjustment with non-zero page size is
deprecated
The change is also important when envy24control is ported to GTK 3, as
the spin buttons will stop working if it's not done.
Closes: https://github.com/alsa-project/alsa-tools/pull/31
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Fix two memory errors in the profiles parser: an invalid read and a
"source and destination overlap in strncpy" warning.
When the profiles page is initialized it fetches the profile names from
the profiles file. When a profile wasn't defined in the file, the parser
made invalid reads outside the buffer.
Closes: https://github.com/alsa-project/alsa-tools/pull/34
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
File descriptors were leaked when "Save active profile" was pressed. Add
the missing calls to close.
Closes: https://github.com/alsa-project/alsa-tools/pull/33
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
envy24control crashed if you tried to start it with -f
/etc/envy24control/profiles.conf.
Closes: https://github.com/alsa-project/alsa-tools/pull/32
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Remove all gtk_widget_show calls and replace it with just one
gtk_widget_show_all. This makes the code shorter and it will also help a
future port to GTK 4, where gtk_widget_show is gone.
Closes: https://github.com/alsa-project/alsa-tools/pull/29
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
The S/PDIF Output Settings in envy24control had some bugs: wrong bits
were set when user changed "Stream" under "Professional" or any of the
settings under "Consumer".
Closes: https://github.com/alsa-project/alsa-tools/pull/28
Signed-off-by: Andreas Persson <andreasp56@outlook.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
* The "Multi Track Peak" control is now of PCM type, to avoid
confusing users in other alsa mixers.
Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
While technically isblank() is a C library function, nothing stops it from
being a macro, and indeed it seems to be on glibc-2.10.
This should not be a problem because ctype.h already declares it on
probably all the systems where it's used.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Please note that LDFLAGS is the _wrong_ variable to pass libraries
with, automake tells you to use _LDADD for binaries and _LIBADD for
libraries, while autoconf wants them in the LIBS variable.
Signed-off-by: Diego 'Flameeyes' Pettenò <flameeyes@gmail.com>
Fixed envy24control to handle ADC volumes with higher resolution
properly.
Also, the bogus sync of gtk_adjustment between ADC and IPGA volumes
is fixed in the case no IPGA is detected.
Support both GTK+ 1.2 and GTK+ 2.x in single configure scripts.
GTK+ 2.x is used unless --with-gtk2=no is given.
If you have no gtk1 or gtk2 devel packages, use configure.in-gtk1
or -gtk2 and do autoreconf.
Change gtk scroll policy for the main notebook pages in envy24control from
ALWAYS to AUTOMATIC; also raise envy24control version.
Signed-off-by: Alan Horstmann <gineera@aspect135.co.uk>
Re-arrange envy24control on-screen; put digital mixer meter in outer frame;
split input and pcm mixer meters; add scroll windows on all notebook pages;
re-layout button boxes; add options -w and -t; add rt-click menu; add pixmap
test to levelmeters.c
Signed-off-by: Alan Horstmann <gineera@aspect135.co.uk>
From: John Rigg <ad@sound-man.co.uk>
I reported a bug in envy24control about the text displayed when using
the BNC word clock input on a Delta 1010 (bug id 0001677). It says
`No signal' when locked and `Locked' when there's no signal. I wasn't
sure how to submit a patch using the Bugtrack interface, so I've
attached it here (this fixes it in alsa-tools-1.0.10).
Remove separate 'breakbox led' selector and use led to indicate 'front line
in' is selected (as it should be); combine digital input select to a
one-of-three selector; change various labels; set default pcm mixer channels
to 6.
Signed-off-by: Alan Horstmann <gineera@aspect135.co.uk>
This patch fixes typo in hardware.c that prevented front digital inputs being
selected on the Terratec DMX6fire. Also renames the digital input controls
for greater clarity with this card.
Signed-off-by: Alan Horstmann <gineera@aspect135.co.uk>
From: Dirk Jagdmann <doj@cubic.org>
The last mail I sent for this topic contained a non functional patch,
which has not been included in CVS yet.
I resend the patch, which should now work.
From: Dirk Jagdmann <doj@cubic.org>
Hello,
this patch adds a command line option to select a better mapping from
midi controller values to dB sliders. The default stays as a linear
mapping, which has the disadvantage, that a sensible area to adjust your
volume (which ist mostly in the range of 0..-12dB) is in the upper
1/10th of your midi controller. This patch adds a map, which consists of
two linear functions, so that the upper half of your midi controller
controls values from 0..-12dB, the lower half then controls -13..-96dB.
From: Dirk Jagdmann <doj@cubic.org>
this patch saves the state of the "LR Gang" buttons in a config/pref file,
because this button's state is not preserved throughout runs of
envy24control. At present it only works, when envy24control is compiled with
GTK2 as I have used routines which were introduced with Glib2.
From: Dirk Jagdmann <doj@cubic.org>
this patch is a bugfix for the midi patch I posted yesterday. This patch
fixes the "mute" button when driven via midi and the "LR Gang" button is
set.
a user has written he has a segmentation fault if he use the profiles
management. He has used some older version of alsa-tools with previous FC
releases until now and then this problem didn't exists.
I have found a array boundary fault in my code for strstr_icase_blank().
From: Dirk Kalis <dirk.kalis@t-online.de>
I have enhanced the midi control of envy24control.
1) I have fixed midi feedback, where issuing a controller event resulted in
the controller value beeing sent to the midi port again.
2) I have added midi controllers for the "mute" buttons, which can now be
controller via midi.
3) and while rewriting the midi code to support the mute buttons several
off-by-one errors have been fixed.
From: Dirk Jagdmann <doj@cubic.org>
