mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-03 09:01:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

alisp: remove alloca() from FA_hctl_elem_write()

Browse source 
Both of alloca() and automatic variables keeps storages on stack, while
the former generates more instructions than the latter. It's better to use
the latter if the size of storage is computable at pre-compile or compile
time; i.e. just for structures.

This commit obsolete usages of alloca() with automatic variables.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2016-07-14 23:07:50 +09:00 • committed by Takashi Iwai
parent 499b0c0401
commit e1d6a2b02f
1 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/alisp/alisp_snd.c
View file

@ -684,8 +684,8 @@ static struct alisp_object * FA_hctl_elem_write(struct alisp_instance * instance
{ {
snd_hctl_elem_t *handle; snd_hctl_elem_t *handle;
struct alisp_object * p1 = NULL, * obj; struct alisp_object * p1 = NULL, * obj;
snd_ctl_elem_info_t *info; snd_ctl_elem_info_t info = {0};
snd_ctl_elem_value_t *value; snd_ctl_elem_value_t value = {0};
snd_ctl_elem_type_t type; snd_ctl_elem_type_t type;
unsigned int idx, count; unsigned int idx, count;
int err; int err;
@ -700,15 +700,13 @@ static struct alisp_object * FA_hctl_elem_write(struct alisp_instance * instance
delete_tree(instance, p1); delete_tree(instance, p1);
return &alsa_lisp_nil; return &alsa_lisp_nil;
} }
snd_ctl_elem_info_alloca(&info); err = snd_hctl_elem_info(handle, &info);
snd_ctl_elem_value_alloca(&value);
err = snd_hctl_elem_info(handle, info);
if (err < 0) { if (err < 0) {
delete_tree(instance, p1); delete_tree(instance, p1);
return new_integer(instance, err); return new_integer(instance, err);
} }
type = snd_ctl_elem_info_get_type(info); type = snd_ctl_elem_info_get_type(&info);
count = snd_ctl_elem_info_get_count(info); count = snd_ctl_elem_info_get_count(&info);
if (type == SND_CTL_ELEM_TYPE_IEC958) { if (type == SND_CTL_ELEM_TYPE_IEC958) {
count = sizeof(snd_aes_iec958_t); count = sizeof(snd_aes_iec958_t);
type = SND_CTL_ELEM_TYPE_BYTES; type = SND_CTL_ELEM_TYPE_BYTES;
@ -722,19 +720,19 @@ static struct alisp_object * FA_hctl_elem_write(struct alisp_instance * instance
obj = car(p1); obj = car(p1);
switch (type) { switch (type) {
case SND_CTL_ELEM_TYPE_BOOLEAN: case SND_CTL_ELEM_TYPE_BOOLEAN:
snd_ctl_elem_value_set_boolean(value, idx, get_integer(obj)); snd_ctl_elem_value_set_boolean(&value, idx, get_integer(obj));
break; break;
case SND_CTL_ELEM_TYPE_INTEGER: case SND_CTL_ELEM_TYPE_INTEGER:
snd_ctl_elem_value_set_integer(value, idx, get_integer(obj)); snd_ctl_elem_value_set_integer(&value, idx, get_integer(obj));
break; break;
case SND_CTL_ELEM_TYPE_INTEGER64: case SND_CTL_ELEM_TYPE_INTEGER64:
snd_ctl_elem_value_set_integer64(value, idx, get_integer(obj)); snd_ctl_elem_value_set_integer64(&value, idx, get_integer(obj));
break; break;
case SND_CTL_ELEM_TYPE_ENUMERATED: case SND_CTL_ELEM_TYPE_ENUMERATED:
snd_ctl_elem_value_set_enumerated(value, idx, get_integer(obj)); snd_ctl_elem_value_set_enumerated(&value, idx, get_integer(obj));
break; break;
case SND_CTL_ELEM_TYPE_BYTES: case SND_CTL_ELEM_TYPE_BYTES:
snd_ctl_elem_value_set_byte(value, idx, get_integer(obj)); snd_ctl_elem_value_set_byte(&value, idx, get_integer(obj));
break; break;
default: default:
break; break;
@ -743,7 +741,7 @@ static struct alisp_object * FA_hctl_elem_write(struct alisp_instance * instance
p1 = cdr(obj = p1); p1 = cdr(obj = p1);
delete_object(instance, obj); delete_object(instance, obj);
} while (p1 != &alsa_lisp_nil); } while (p1 != &alsa_lisp_nil);
err = snd_hctl_elem_write(handle, value); err = snd_hctl_elem_write(handle, &value);
return new_integer(instance, err); return new_integer(instance, err);
} }