mirrors/alsa-lib
1
0
Fork 0
mirror of https://github.com/alsa-project/alsa-lib.git synced 2025-11-05 13:30:00 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

topology: move the elem->list delete to tplg_elem_free()

Browse source 
The tplg_elem_free() is called in the error path from many places
and it is expected that the element object will be unregistered
from the tplg structure, too.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This commit is contained in:
Jaroslav Kysela 2020-01-03 22:07:11 +01:00
parent b6c9afb4f5
commit cb88813ff7
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/topology/elem.c
View file

@ -301,6 +301,8 @@ struct tplg_elem *tplg_elem_new(void)
void tplg_elem_free(struct tplg_elem *elem) void tplg_elem_free(struct tplg_elem *elem)
{ {
list_del(&elem->list);
tplg_ref_free_list(&elem->ref_list); tplg_ref_free_list(&elem->ref_list);
/* free struct snd_tplg_ object, /* free struct snd_tplg_ object,
@ -323,7 +325,6 @@ void tplg_elem_free_list(struct list_head *base)
list_for_each_safe(pos, npos, base) { list_for_each_safe(pos, npos, base) {
elem = list_entry(pos, struct tplg_elem, list); elem = list_entry(pos, struct tplg_elem, list);
list_del(&elem->list);
tplg_elem_free(elem); tplg_elem_free(elem);
} }
} }